Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Create snapshot from VM snapshot without memory for NFS/Local storage#8117

Merged
DaanHoogland merged 2 commits intoapache:4.18apache/cloudstack:4.18from
storpool:snapshot-from-vmsnapshotstorpool/cloudstack:snapshot-from-vmsnapshotCopy head branch name to clipboard
Oct 26, 2023
Merged

Create snapshot from VM snapshot without memory for NFS/Local storage#8117
DaanHoogland merged 2 commits intoapache:4.18apache/cloudstack:4.18from
storpool:snapshot-from-vmsnapshotstorpool/cloudstack:snapshot-from-vmsnapshotCopy head branch name to clipboard

Conversation

@slavkap
Copy link
Contributor

@slavkap slavkap commented Oct 18, 2023 •
edited
Loading

Description

This PR fixes #8078

The volume snapshot will be created only on secondary storage.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Hypervisor KVM
Primary storage NFS

  • take volume snapshot from VM snapshot without memory
  • create volume from that snapshot
  • crate template from the snapshot and deploy a VM

DaanHoogland
DaanHoogland approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slavkap, can you put the new/changed bits of code in new methods?
clgtm otherwise

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 18, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #8117 (1c8cbc9) into 4.18 (0183e25) will increase coverage by 0.00%.
Report is 6 commits behind head on 4.18.
The diff coverage is 16.66%.

@@            Coverage Diff            @@
##               4.18    #8117   +/-   ##
=========================================
  Coverage     13.06%   13.06%           
- Complexity     9108     9110    +2     
=========================================
  Files          2720     2720           
  Lines        257531   257568   +37     
  Branches      40150    40154    +4     
=========================================
+ Hits          33655    33660    +5     
- Misses       219648   219677   +29     
- Partials       4228     4231    +3
Files Coverage Δ
...tack/storage/motion/AncientDataMotionStrategy.java 2.28% <0.00%> (-0.04%) ⬇️
...om/cloud/storage/snapshot/SnapshotManagerImpl.java 16.72% <35.00%> (+0.04%) ⬆️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 4.97% <0.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6209

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 19, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 19, 2023

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr
yadvr approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slavkap - didn't test it bu LGTM

@yadvr yadvr added this to the 4.18.2.0 milestone Oct 19, 2023
@blueorangutan
Copy link

blueorangutan commented Oct 19, 2023

[SF] Trillian test result (tid-8009)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40457 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8009-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 39.60 test_templates.py
test_09_list_templates_download_details Failure 0.04 test_templates.py

@yadvr yadvr requested a review from shwstppr October 20, 2023 09:36
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 20, 2023

@slavkap is this ready? Can you add test info?

@slavkap
Copy link
Contributor Author

slavkap commented Oct 23, 2023

@DaanHoogland, it's ready

@yadvr
Copy link
Member

yadvr commented Oct 25, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7499

yadvr
yadvr approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the following with local storage on adv zone kvm env:

  1. create vm snapshot of a Ubuntu 22.04 VM with qemu-guest-agent running - pass
  2. tested vm snapshot revert on a stopped VM - pass
  3. created volume snapshot from VM snapshot - pass
  4. created template from this volume snapshot in step-3 and deployed VM - pass

@yadvr
Copy link
Member

yadvr commented Oct 25, 2023

@blueorangutan test matrix

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

[SF] Trillian test result (tid-8090)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42411 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8090-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 681.68 test_kubernetes_clusters.py

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

[SF] Trillian test result (tid-8088)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42553 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8088-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

blueorangutan commented Oct 25, 2023

[SF] Trillian test result (tid-8089)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 49240 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8117-t8089-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 6ae3b73 into apache:4.18 Oct 26, 2023
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023
@slavkap @yadvr
Create snapshot from VM snapshot without memory for NFS/Local storage (…
a768c96 
…apache#8117)

(cherry picked from commit 6ae3b73)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

component:api component:kvm component:storage

Projects

None yet

Milestone

4.18.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@slavkap @DaanHoogland @blueorangutan @yadvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.