Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: add test for standalone snapshot#8104

Merged
shwstppr merged 1 commit intoapache:4.18apache/cloudstack:4.18from
shapeblue:add-test-snap-standaloneshapeblue/cloudstack:add-test-snap-standaloneCopy head branch name to clipboard
Oct 19, 2023
Merged

test: add test for standalone snapshot#8104
shwstppr merged 1 commit intoapache:4.18apache/cloudstack:4.18from
shapeblue:add-test-snap-standaloneshapeblue/cloudstack:add-test-snap-standaloneCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Oct 16, 2023 •
edited
Loading

Description

Fixes #8034

Adds the following test for a backed-up snapshot (original template and VM deleted beforehand):

  • Create volume from snapshot
  • Create a template from the snapshot and deploy a VM using it

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
test: add test for standalone snapshot
6f05ed6 
Fixes apache#8034

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Oct 16, 2023
@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 16, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2023

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 16, 2023

ui build fails with

npm ERR! This is an error with npm itself. Please report this error at:
npm ERR!     <https://npm.community/>

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-10-16T13_06_23_305Z-debug.log

I didn´t see this one before, but might mean we need to upgrade npm??? cc @rohityadavcloud ?

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #8104 (6f05ed6) into 4.18 (3e7f21a) will increase coverage by 15.51%.
Report is 6 commits behind head on 4.18.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               4.18    #8104       +/-   ##
=============================================
+ Coverage     13.06%   28.57%   +15.51%     
- Complexity     9109    31199    +22090     
=============================================
  Files          2720     5101     +2381     
  Lines        257526   379527   +122001     
  Branches      40150    61382    +21232     
=============================================
+ Hits          33655   108465    +74810     
- Misses       219644   256120    +36476     
- Partials       4227    14942    +10715
Flag Coverage Δ
simulator-marvin-tests 25.24% <ø> (?)
uitests 4.84% <ø> (?)
unit-tests 14.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3670 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7386

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 16, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 16, 2023

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@shwstppr shwstppr closed this Oct 16, 2023
@shwstppr shwstppr reopened this Oct 16, 2023
@blueorangutan
Copy link

blueorangutan commented Oct 17, 2023

[SF] Trillian test result (tid-7983)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8104-t7983-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 576.50 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 623.90 test_kubernetes_clusters.py
test_03_deploy_vm_wrong_checksum Error 40.70 test_templates.py
test_09_list_templates_download_details Failure 0.05 test_templates.py

@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 17, 2023

Template failures are unrelated and have been fixed in #8096

@shwstppr shwstppr changed the base branch from main to 4.18 October 17, 2023 11:16
@shwstppr shwstppr closed this Oct 17, 2023
@shwstppr shwstppr reopened this Oct 17, 2023
@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 17, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 17, 2023

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

yadvr
yadvr approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @shwstppr for adding test case

@yadvr yadvr added this to the 4.18.2.0 milestone Oct 17, 2023
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Oct 17, 2023

@blueorangutan test

borisstoyanov
borisstoyanov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, let's wait for test results

@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 18, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7410

@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 18, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache
weizhouapache approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

blueorangutan commented Oct 18, 2023

[SF] Trillian test result (tid-7996)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8104-t7996-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 40.61 test_templates.py
test_09_list_templates_download_details Failure 0.04 test_templates.py

@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 19, 2023

Merging this based on the test results

@shwstppr shwstppr merged commit 540c7b8 into apache:4.18 Oct 19, 2023
@shwstppr shwstppr mentioned this pull request Oct 19, 2023
Closed
shwstppr added a commit to shapeblue/cloudstack that referenced this pull request Dec 27, 2023
@shwstppr @yadvr
test: add test for standalone snapshot (apache#8104)
f4b9e6c 
Fixes apache#8034

Adds the following test for a backed-up snapshot (original template and VM deleted beforehand):
- Create volume from snapshot
- Create a template from the snapshot and deploy a VM using it

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
(cherry picked from commit 540c7b8)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.18.2.0

Development

Successfully merging this pull request may close these issues.

KVM volume snapshots are not full snapshots anymore

6 participants

@shwstppr @blueorangutan @DaanHoogland @borisstoyanov @yadvr @weizhouapache
Morty Proxy This is a proxified and sanitized view of the page, visit original site.