Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High#764
Closed
karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
Closed
Fix findbugs issue: 76, DM_DEFAULT_ENCODING, Priority: High#764karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
Conversation
ex.printStacktrace prints to System.err by default. Used it and removed the printwriter which was causing the findbugs issue. Also, I do not see a reason to write the stacktrace both to stdout and stderr. But, keeping it as is for now
|
cloudstack-pull-rats #451 SUCCESS |
Contributor
|
@karuturi please have a look at https://github.com/apache/cloudstack/pull/762/files Your solution will work but I like the other one as well. |
|
cloudstack-pull-analysis #384 SUCCESS |
Member
Author
|
closing in favor of a better fix @ #762 |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
JoaoJandre
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Nov 24, 2022
Correção no script que executa alteração de senha em hosts Closes apache#764 See merge request scclouds/scclouds!309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ex.printStacktrace prints to System.err by default. Used it and removed
the printwriter which was causing the findbugs issue.
Also, I do not see a reason to write the stacktrace both to stdout and
stderr. But, keeping it as is for now
This fixes the findbugs issues which is reported as new in http://jenkins.buildacloud.org/job/build-master-slowbuild/2191/findbugsResult/new/