cks: k8s cluster on vpc tier#7479
cks: k8s cluster on vpc tier#7479yadvr merged 14 commits intoapache:4.18apache/cloudstack:4.18from shapeblue:cks-cluster-on-vpc-tiershapeblue/cloudstack:cks-cluster-on-vpc-tierCopy head branch name to clipboard
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Great job ! @shwstppr |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5988 |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7479 +/- ##
==========================================
Coverage 12.97% 12.98%
- Complexity 8964 8980 +16
==========================================
Files 2716 2716
Lines 256153 256307 +154
Branches 39948 39967 +19
==========================================
+ Hits 33226 33271 +45
- Misses 218767 218874 +107
- Partials 4160 4162 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
SonarCloud Quality Gate failed. |
| throw new InvalidParameterValueException(String.format("Network ID: %s has conflicting port forwarding rules to provision Kubernetes cluster for node VM SSH access", network.getUuid())); | ||
| } | ||
| } | ||
| rules = firewallRulesDao.listByIpAndPurposeAndNotRevoked(sourceNatIp.getId(), FirewallRule.Purpose.PortForwarding); |
There was a problem hiding this comment.
Can we extract L380 - L 391 , as it seems similar to L366 - L377?
...src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterDestroyWorker.java
Show resolved
Hide resolved
| }); | ||
| rulesService.applyPortForwardingRules(publicIp.getId(), account); | ||
| if (LOGGER.isInfoEnabled()) { | ||
| LOGGER.info(String.format("Provisioned SSH port forwarding rule: %s from port %d to 22 on %s to the VM IP : %s in Kubernetes cluster : %s", pfRule.getUuid(), sourcePort, publicIp.getAddress().addr(), vmIp.toString(), kubernetesCluster.getName())); |
There was a problem hiding this comment.
nit: we could probably replace the hard coded end port (22) to the constant DEFAULT_SSH_PORT to be safer..
|
@Pearl1594 cluster deployment isn't working as of now that's why in draft. Not sure why, need to debug. Will address your comments alongwith fixes. |
@shwstppr |
|
@weizhouapache don't think so as it doesn't play a role during the cluster deployment. Last I tested it seems to be no setting up services defined in the YAML so could be something related to cloud-init or some issue with MS and node VM connectivity. I've redone my setup and will debug. Will keep you guys updated |
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@weizhouapache @Pearl1594 update: cluster deployment is working fine now in my tests. Will do some more tests and will add some unit tests before marking this ready for review |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6055 |
|
great @shwstppr can you add a smoke test for it ? |
@weizhouapache should I add a smoke test in the existing |
@shwstppr we do not need to test the full life cycle of cks cluster on vpc tier. |
|
@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-6591) |
|
@blueorangutan LLtest |
|
@shwstppr a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
vladimirpetrov
left a comment
There was a problem hiding this comment.
LGTM based on manual testing.
|
[LL]Trillian test result (tid-6545)
|
|
@blueorangutan LLpackage |
|
@shwstppr a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
Packaging result [LL]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 6058 |
|
@blueorangutan LLpackage |
|
@shwstppr a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6060 |
|
@blueorangutan LLtest |
|
@shwstppr a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[LL]Trillian test result (tid-6559)
|
|
@weizhouapache @DaanHoogland @rohityadavcloud can we proceed with this? Already tested by @vladimirpetrov and smoke test failures are unrelated |
|
I think we can merge @shwstppr , but let me do another build/test-round. |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6186 |
|
@blueorangutan test |
|
@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-6639)
|
Description
Fixes #6723
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?