Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input#733

Merged
asfgit merged 1 commit intoapache:4.5apache/cloudstack:4.5from
shapeblue:kvm-linkbr-checksshapeblue/cloudstack:kvm-linkbr-checksCopy head branch name to clipboard
Aug 26, 2015
Merged

CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input#733
asfgit merged 1 commit intoapache:4.5apache/cloudstack:4.5from
shapeblue:kvm-linkbr-checksshapeblue/cloudstack:kvm-linkbr-checksCopy head branch name to clipboard

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Aug 24, 2015

Based on @jburwell's comment on PR #718

@asfbot
Copy link

asfbot commented Aug 24, 2015

cloudstack-pull-rats #377 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Aug 24, 2015

cloudstack-pull-analysis #310 SUCCESS
This pull request looks good

@remibergsma
Copy link
Contributor

remibergsma commented Aug 24, 2015

@bhaisaab Can you send this PR against master please? For now, I'd rather merge to master, then cherry-pick back to 4.5 as I want to prevent all the cherry-picks in master (as we need to put them in a PR anyway in order for the tests to run first).

Once 4.6 is out and we'll be working on 4.7, we'll be able to send PRs against 4.6, then merge forward to 4.7/master.

Pinging @karuturi

@yadvr
Copy link
Member Author

yadvr commented Aug 24, 2015

@remibergsma merges cleanly on master, if you LGTM; I can merge this on master and 4.5

@yadvr
Copy link
Member Author

yadvr commented Aug 24, 2015

@remibergsma sending another PR just for master

@yadvr
Copy link
Member Author

yadvr commented Aug 24, 2015

@remibergsma here: #735

@remibergsma
Copy link
Contributor

remibergsma commented Aug 24, 2015

@bhaisaab Thanks, now the tests can run on master as well :-)

@remibergsma
Copy link
Contributor

remibergsma commented Aug 24, 2015

LGTM on this one, will do the other once the tests are done.

@remibergsma
Copy link
Contributor

remibergsma commented Aug 24, 2015

@jburwell can you review this please? Thanks!

@jburwell
Copy link
Contributor

jburwell commented Aug 25, 2015

See comments on PR #735 regarding extracting the parsing logic and unit testing.

@yadvr
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
2a382e0 
Based on @jburwell's comment on PR apache#718

This closes apache#733

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr force-pushed the kvm-linkbr-checks branch from 86d29c4 to 2a382e0 Compare August 26, 2015 08:06
@asfbot
Copy link

asfbot commented Aug 26, 2015

cloudstack-pull-rats #404 SUCCESS
This pull request looks good

@asfgit asfgit merged commit 2a382e0 into apache:4.5 Aug 26, 2015
asfgit pushed a commit that referenced this pull request Aug 26, 2015
@yadvr
Merge pull request #733 from shapeblue/kvm-linkbr-checks
acf1baf 
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/733:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@asfbot
Copy link

asfbot commented Aug 26, 2015

cloudstack-pull-analysis #337 UNSTABLE
Looks like there's a problem with this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yadvr @asfbot @remibergsma @jburwell @asfgit
Morty Proxy This is a proxified and sanitized view of the page, visit original site.