Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

vmware: do not create vm datastore when attach an existing volume on solidfire#7160

Merged
weizhouapache merged 1 commit intoapache:4.18apache/cloudstack:4.18from
weizhouapache:4.17-fix-vmware-solidfire-attach-volumeweizhouapache/cloudstack:4.17-fix-vmware-solidfire-attach-volumeCopy head branch name to clipboard
Jun 1, 2023
Merged

vmware: do not create vm datastore when attach an existing volume on solidfire#7160
weizhouapache merged 1 commit intoapache:4.18apache/cloudstack:4.18from
weizhouapache:4.17-fix-vmware-solidfire-attach-volumeweizhouapache/cloudstack:4.17-fix-vmware-solidfire-attach-volumeCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Feb 1, 2023 •
edited by DaanHoogland
Loading

Description

This PR may fix #7148 , solidfire users are requested to test it.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Contributor Author

weizhouapache commented Feb 1, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Feb 1, 2023

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Feb 1, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5481

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@apache apache deleted a comment from blueorangutan Feb 2, 2023
@weizhouapache
Copy link
Contributor Author

weizhouapache commented Feb 2, 2023

@blueorangutan test rocky8 vmware-70u3

@blueorangutan
Copy link

blueorangutan commented Feb 2, 2023

@weizhouapache a Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Feb 2, 2023

Trillian Build Failed (tid-6085)

@yadvr yadvr changed the base branch from main to 4.18 March 31, 2023 11:08
@yadvr
Copy link
Member

yadvr commented May 8, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 8, 2023

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 8, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6040

DaanHoogland
DaanHoogland approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cLGTM

shwstppr
shwstppr approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@shwstppr
Copy link
Contributor

shwstppr commented May 11, 2023

@blueorangutan test rocky8 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented May 11, 2023

@shwstppr a Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 11, 2023

Trillian test result (tid-6529)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 54843 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7160-t6529-vmware-67u3.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_deploy_vm_on_specific_host Error 18.67 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 3602.74 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 1.32 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 2.31 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 2.30 test_vm_deployment_planner.py
test_09_expunge_vm Failure 424.61 test_vm_life_cycle.py

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone May 12, 2023
@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 24, 2023

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@weizhouapache
Copy link
Contributor Author

weizhouapache commented May 24, 2023

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland
I am ok with merging this. but you know, I am the author :-)

@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 24, 2023

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

@weizhouapache weizhouapache marked this pull request as ready for review May 24, 2023 12:38
@weizhouapache
Copy link
Contributor Author

weizhouapache commented May 24, 2023

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

ah, moved it to "ready for review".
I will merge this if there is no objection until the end of Friday

@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 25, 2023

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

ah, moved it to "ready for review". I will merge this if there is no objection until the end of Friday

ok, let's merge as you suggested but keep the issue open as @rohityadavcloud suggested until a solidfire user confirmed.

@weizhouapache weizhouapache merged commit b2e9993 into apache:4.18 Jun 1, 2023
@weizhouapache weizhouapache deleted the 4.17-fix-vmware-solidfire-attach-volume branch June 23, 2023 13:13
@yadvr
Copy link
Member

yadvr commented Jul 7, 2023

@weizhouapache I've tested this fix backported to a 4.17 env with Solidfire and VMware; it fixes the issue of previously failured where it would attempt to create datastore on an already created datastore for a solidfire iSCSI target. However, it doesn't address the issue #7148 completely.

@yadvr yadvr mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr left review comments

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:vmware

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

[SolidFire] Cannot attach volume which is detached from VM

5 participants

@weizhouapache @blueorangutan @yadvr @shwstppr @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.