Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Gateways after Nic update on Shared Network tests#6355

Merged
nvazquez merged 2 commits intoapache:mainapache/cloudstack:mainfrom
shapeblue:gatewaysOnSharedNetworkTestsshapeblue/cloudstack:gatewaysOnSharedNetworkTestsCopy head branch name to clipboard
May 5, 2022
Merged

Gateways after Nic update on Shared Network tests#6355
nvazquez merged 2 commits intoapache:mainapache/cloudstack:mainfrom
shapeblue:gatewaysOnSharedNetworkTestsshapeblue/cloudstack:gatewaysOnSharedNetworkTestsCopy head branch name to clipboard

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR add a test to verify that the right gateways and netmasks are set on updates of IPs from a different range on shared networks. This was fixed in #5105

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

integration test only

@DaanHoogland DaanHoogland added this to the 4.17.0.0 milestone May 4, 2022
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6355 (SL-JID-1522)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nvazquez
Copy link
Contributor

nvazquez commented May 5, 2022

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3351

Copy link
Contributor

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passed in my testing

@weizhouapache
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-4124)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40127 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6355-t4124-kvm-centos7.zip
Smoke tests completed. 95 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_create_template_with_no_checksum Error 65.48 test_templates.py

@nvazquez nvazquez merged commit f572c7a into apache:main May 5, 2022
DaanHoogland added a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.