Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

UI: checksum field is optional for direct-download templates on kvm#6290

Merged
nvazquez merged 1 commit intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.17-ui-optional-checksumweizhouapache/cloudstack:4.17-ui-optional-checksumCopy head branch name to clipboard
Apr 20, 2022
Merged

UI: checksum field is optional for direct-download templates on kvm#6290
nvazquez merged 1 commit intoapache:mainapache/cloudstack:mainfrom
weizhouapache:4.17-ui-optional-checksumweizhouapache/cloudstack:4.17-ui-optional-checksumCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Contributor

@weizhouapache weizhouapache commented Apr 20, 2022

Description

This PR fixes the UI issue that checksum field is required on UI.
this is a regression of #5151

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Apr 20, 2022
@acs-robot
Copy link

acs-robot commented Apr 20, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@acs-robot
Copy link

acs-robot commented Apr 20, 2022

Found Java/XML changes, kicking packaging job
@blueorangutan package

@acs-robot
Copy link

acs-robot commented Apr 20, 2022

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
Volume 109 0 2 0 44 0
VolumeVO 529 133 4 0 179 39
VolumeObject 773 665 77 39 178 117
VmwareStorageProcessor 9892 9 940 0 2122 2
VolumeJoinDaoImpl 770 0 94 0 171 0
VolumeJoinVO 267 0 0 0 93 0
ConfigurationManagerImpl 18104 0 3032 0 3570 0
IpAddressManagerImpl 4045 0 461 0 806 0
ManagementServerImpl 11819 0 1052 0 2361 0
VolumeApiServiceImpl 10851 0 1500 0 2035 0
VirtualMachineMO 8953 135 1063 17 1982 31

utchoang
utchoang approved these changes Apr 20, 2022
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez merged commit 9f076ff into apache:main Apr 20, 2022
@weizhouapache weizhouapache deleted the 4.17-ui-optional-checksum branch December 9, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @acs-robot @nvazquez @Pearl1594 @utchoang
Morty Proxy This is a proxified and sanitized view of the page, visit original site.