Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ui: fix add network offering for vpc#5809

Merged
yadvr merged 3 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:fix-ui-add-network-offshapeblue/cloudstack:fix-ui-add-network-offCopy head branch name to clipboard
Dec 30, 2021
Merged

ui: fix add network offering for vpc#5809
yadvr merged 3 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:fix-ui-add-network-offshapeblue/cloudstack:fix-ui-add-network-offCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Dec 24, 2021

Description

Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.

Fixes #5807

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
ui: fix add network offering for vpc
74bf140 
Fixes issues with form related to supported services provider and router service offering when offering to be created for VPC.

Fixes apache#5807

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Dec 24, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Dec 24, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 24, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-934)

@utchoang utchoang mentioned this pull request Dec 24, 2021
Merged
12 tasks
@utchoang
Copy link

utchoang commented Dec 24, 2021

@shwstppr I have a PR to fix the problem you have when changing the VPC selection. you can take a look and merge it here. Thanks

@sureshanaparti sureshanaparti requested review from Pearl1594 and utchoang and removed request for utchoang December 27, 2021 20:02
@utchoang
Copy link

utchoang commented Dec 28, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Dec 28, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 28, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-941)

utchoang
utchoang approved these changes Dec 28, 2021
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pearl1594
Copy link
Contributor

Pearl1594 commented Dec 29, 2021 •
edited
Loading

@shwstppr I notice there to be an issue when we toggle the VPC switch in the network offering form, i.e., when it is turned on, and we check the services to be supported, it still lists VirtualRouter (The cache was cleared prior to verifying the fix):

image

@shwstppr
fixes
ddfa388 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Dec 29, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Dec 29, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 29, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5809 (SL-JID-948)

@sureshanaparti sureshanaparti added this to the 4.16.1.0 milestone Dec 29, 2021
@shwstppr
Copy link
Contributor Author

shwstppr commented Dec 29, 2021

@Pearl1594 can you please try now

Pearl1594
Pearl1594 approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shwstppr. Works as expected.

@shwstppr shwstppr marked this pull request as ready for review December 30, 2021 10:08
@yadvr yadvr merged commit d7a9873 into apache:4.16 Dec 30, 2021
@weizhouapache weizhouapache mentioned this pull request Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @blueorangutan @utchoang @Pearl1594 @yadvr @sureshanaparti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.