ui-primary-storage: hide provider if Linstor protocol#5672
Merged
yadvr merged 2 commits intoapache:4.16apache/cloudstack:4.16from Nov 18, 2021
LINBIT:ui-primarystorage-hide-provider-on-linstor-protocolLINBIT/cloudstack:ui-primarystorage-hide-provider-on-linstor-protocolCopy head branch name to clipboard
Merged
ui-primary-storage: hide provider if Linstor protocol#5672yadvr merged 2 commits intoapache:4.16apache/cloudstack:4.16from LINBIT:ui-primarystorage-hide-provider-on-linstor-protocolLINBIT/cloudstack:ui-primarystorage-hide-provider-on-linstor-protocolCopy head branch name to clipboard
yadvr merged 2 commits intoapache:4.16apache/cloudstack:4.16from
LINBIT:ui-primarystorage-hide-provider-on-linstor-protocolLINBIT/cloudstack:ui-primarystorage-hide-provider-on-linstor-protocolCopy head branch name to clipboard
Conversation
If Linstor protocol is selected it makes no sense to show other providers as Linstor only works with the Linstor provider. This was removed with the fix for apache#5613, that probably resulted from a bad merge resolving from my part.
Contributor
Author
|
I added another fix for the setup-wizard, which didn't set the correct provider for Linstor and would have failed. |
Member
|
@GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
yadvr
pushed a commit
that referenced
this pull request
Jun 22, 2022
If Linstor protocol is selected it makes no sense to show other providers as Linstor only works with the Linstor provider. And also the install wizard doesn't use the correct provider for linstor. This changes were already merged for 4.16.1.0 see: #5672 But I don't know why they weren't merged to main back than, maybe I don't know how cloudstack's merge/PR's work. But this should be definitely merged to 4.17.* and main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If Linstor protocol is selected it makes no sense to show other
providers as Linstor only works with the Linstor provider.
This was removed with the fix for #5613, that probably resulted from a
bad merge resolving from my part.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Clicked through local served vui ui -> add primary storage