Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

ui: fix create user domain, account selection#5487

Merged
sureshanaparti merged 5 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:fix-userform-configuressoshapeblue/cloudstack:fix-userform-configuressoCopy head branch name to clipboard
Jan 17, 2022
Merged

ui: fix create user domain, account selection#5487
sureshanaparti merged 5 commits intoapache:4.16apache/cloudstack:4.16from
shapeblue:fix-userform-configuressoshapeblue/cloudstack:fix-userform-configuressoCopy head branch name to clipboard

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Sep 21, 2021 •
edited
Loading

Description

  • Fixes domain, account selection for new user
  • Refreshes user details on configuring SAML SSO

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

domainaccountfilter

How Has This Been Tested?

@shwstppr
ui: fix create user domain, account selection
4fd4e19 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Sep 21, 2021
Merged
12 tasks
@shwstppr
fetch accounts only after domains
1680939 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
refresh on saml configure
1ad4ff2 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Sep 21, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Sep 21, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 21, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5487 (SL-JID-679)

@yadvr yadvr changed the base branch from main to 4.16 November 15, 2021 10:10
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 25, 2021
@shwstppr shwstppr marked this pull request as ready for review January 17, 2022 06:09
utchoang
utchoang approved these changes Jan 17, 2022
View reviewed changes
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jan 17, 2022

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5487 (SL-JID-1026)

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jan 17, 2022

Hi @shwstppr When changing the domain, the account shown/selected doesn't change while the account list items reflects new accounts from the changed domain. Please check.

@shwstppr
Merge branch '4.16' into fix-userform-configuresso
a69aac1
@shwstppr
change
3ecbee4 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jan 17, 2022

@blueorangutan ui

@sureshanaparti fixed

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

UI build: ✖️
(SL-JID-1027)

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jan 17, 2022

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 17, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5487 (SL-JID-1030)

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Jan 17, 2022

Verified accounts listed in the selected domain while creating user from UI. LGTM.

@sureshanaparti sureshanaparti merged commit f5b0d2f into apache:4.16 Jan 17, 2022
@weizhouapache weizhouapache mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang utchoang approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees

@shwstppr shwstppr

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @sureshanaparti @utchoang @yadvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.