server: skip zone check for PERHOST iso during attachIso by shwstppr · Pull Request #5270 · apache/cloudstack

shwstppr · Aug 3, 2021

Description

Hypervisor tools ISO - vmware-toools.iso, xs-tools.iso are marked as PERHOST in DB. They are active but not downloaded to the secondary storages and hence no template-zone entry.
Skips the template-zone check for such templates.

Fixes #5265

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Error on attach ISO:

How Has This Been Tested?

Using cmk with an env (VMware advanced zone)

Before fix:

(localcloud) SBCM5> > list isos id=8fd33e21-d145-4b23-91f0-a0cecc9429fa isofilter=self
{
  "count": 1,
  "iso": [
    {
      "account": "system",
      "bits": 64,
      "bootable": false,
      "crossZones": false,
      "directdownload": false,
      "displaytext": "VMware Tools Installer ISO",
      "domain": "ROOT",
      "domainid": "c4a349e5-f487-11eb-ac74-1e0019000402",
      "id": "8fd33e21-d145-4b23-91f0-a0cecc9429fa",
      "isdynamicallyscalable": false,
      "isextractable": false,
      "isfeatured": true,
      "ispublic": true,
      "isready": true,
      "name": "vmware-tools.iso",
      "ostypeid": "c4aaad30-f487-11eb-ac74-1e0019000402",
      "ostypename": "CentOS 4.5 (32-bit)",
      "passwordenabled": false,
      "tags": []
    }
  ]
}
(localcloud) SBCM5> > list virtualmachines id=8dbc5889-cdce-49f7-a23b-a3e862c5316d
{
  "count": 1,
  "virtualmachine": [
    {
      "account": "admin",
      "affinitygroup": [],
      "cpunumber": 1,
      "cpuspeed": 500,
      "cpuused": "0%",
      "created": "2021-08-03T18:52:00+0000",
      "details": {
        "cpuOvercommitRatio": "2.0",
        "dataDiskController": "osdefault",
        "memoryOvercommitRatio": "1.0",
        "rootDiskController": "ide"
      },
      "diskioread": 62,
      "diskiowrite": 46,
      "diskkbsread": 2512,
      "diskkbswrite": 349,
      "diskofferingid": "a93176e0-6392-4e39-aa30-c798ca33cae1",
      "diskofferingname": "Large",
      "displayname": "t1",
      "displayvm": true,
      "domain": "ROOT",
      "domainid": "c4a349e5-f487-11eb-ac74-1e0019000402",
      "guestosid": "c4ac616b-f487-11eb-ac74-1e0019000402",
      "haenable": false,
      "hostid": "8a14a9f9-ebbc-4eaa-9f57-940a3210e913",
      "hostname": "10.0.32.172",
      "hypervisor": "VMware",
      "id": "8dbc5889-cdce-49f7-a23b-a3e862c5316d",
      "instancename": "i-2-3-VM",
      "isdynamicallyscalable": false,
      "memory": 512,
      "memoryintfreekbs": 393216,
      "memorykbs": 524288,
      "memorytargetkbs": 524288,
      "name": "t1",
      "networkkbsread": 0,
      "networkkbswrite": 0,
      "nic": [
        {
          "broadcasturi": "vlan://1530",
          "extradhcpoption": [],
          "gateway": "10.1.1.1",
          "id": "eabbdb90-aa81-4e8a-8da3-02de530b3df0",
          "ipaddress": "10.1.1.192",
          "isdefault": true,
          "isolationuri": "vlan://1530",
          "macaddress": "02:00:6c:ea:00:01",
          "netmask": "255.255.255.0",
          "networkid": "33dd6451-bc69-4587-ae9e-e2add4263d9c",
          "networkname": "net1",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated"
        }
      ],
      "osdisplayname": "CentOS 5.3 (64-bit)",
      "ostypeid": "c4ac616b-f487-11eb-ac74-1e0019000402",
      "passwordenabled": false,
      "rootdeviceid": 0,
      "rootdevicetype": "ROOT",
      "securitygroup": [],
      "serviceofferingid": "01410b2a-4471-4a7c-9e2d-84fd9ebff363",
      "serviceofferingname": "Small Instance",
      "state": "Running",
      "tags": [],
      "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
      "templateid": "c4a8b7d0-f487-11eb-ac74-1e0019000402",
      "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
      "userid": "dd534934-f487-11eb-ac74-1e0019000402",
      "username": "admin",
      "zoneid": "358d9914-5590-4b6a-b615-ae3b83af52fa",
      "zonename": "ref-trl-1450-v-M7-abhishek-kumar"
    }
  ]
}
(localcloud) SBCM5> > attach iso virtualmachineid=8dbc5889-cdce-49f7-a23b-a3e862c5316d id="8fd33e21-d145-4b23-91f0-a0cecc9429fa"
{
  "accountid": "dd522416-f487-11eb-ac74-1e0019000402",
  "cmd": "org.apache.cloudstack.api.command.admin.iso.AttachIsoCmdByAdmin",
  "completed": "2021-08-03T18:56:19+0000",
  "created": "2021-08-03T18:56:18+0000",
  "jobid": "a776dfb2-130b-40a9-a8d5-1d0e1b9cf83b",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 431,
    "errortext": "ISO is not available in the zone the VM is in."
  },
  "jobresultcode": 530,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "dd534934-f487-11eb-ac74-1e0019000402"
}
� Error: async API failed for job a776dfb2-130b-40a9-a8d5-1d0e1b9cf83b

After fix:

(localcloud) SBCM5> > attach iso virtualmachineid=8dbc5889-cdce-49f7-a23b-a3e862c5316d id="8fd33e21-d145-4b23-91f0-a0cecc9429fa"
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "5%",
    "created": "2021-08-03T18:52:00+0000",
    "details": {
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "ide"
    },
    "diskioread": 0,
    "diskiowrite": 0,
    "diskkbsread": 0,
    "diskkbswrite": 0,
    "diskofferingid": "a93176e0-6392-4e39-aa30-c798ca33cae1",
    "diskofferingname": "Large",
    "displayname": "t1",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "c4a349e5-f487-11eb-ac74-1e0019000402",
    "guestosid": "c4ac616b-f487-11eb-ac74-1e0019000402",
    "haenable": false,
    "hostid": "8a14a9f9-ebbc-4eaa-9f57-940a3210e913",
    "hostname": "10.0.32.172",
    "hypervisor": "VMware",
    "id": "8dbc5889-cdce-49f7-a23b-a3e862c5316d",
    "instancename": "i-2-3-VM",
    "isdynamicallyscalable": false,
    "isodisplaytext": "VMware Tools Installer ISO",
    "isoid": "8fd33e21-d145-4b23-91f0-a0cecc9429fa",
    "isoname": "vmware-tools.iso",
    "memory": 512,
    "memoryintfreekbs": 77824,
    "memorykbs": 524288,
    "memorytargetkbs": 524288,
    "name": "t1",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "broadcasturi": "vlan://1530",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "eabbdb90-aa81-4e8a-8da3-02de530b3df0",
        "ipaddress": "10.1.1.192",
        "isdefault": true,
        "isolationuri": "vlan://1530",
        "macaddress": "02:00:6c:ea:00:01",
        "netmask": "255.255.255.0",
        "networkid": "33dd6451-bc69-4587-ae9e-e2add4263d9c",
        "networkname": "net1",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "CentOS 5.3 (64-bit)",
    "ostypeid": "c4ac616b-f487-11eb-ac74-1e0019000402",
    "passwordenabled": false,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "01410b2a-4471-4a7c-9e2d-84fd9ebff363",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "templateid": "c4a8b7d0-f487-11eb-ac74-1e0019000402",
    "templatename": "CentOS 5.3(64-bit) no GUI (vSphere)",
    "userid": "dd534934-f487-11eb-ac74-1e0019000402",
    "username": "admin",
    "zoneid": "358d9914-5590-4b6a-b615-ae3b83af52fa",
    "zonename": "ref-trl-1450-v-M7-abhishek-kumar"
  }
}

Hypervisor tools ISO - vmware-toools.iso, xs-tools.iso are marked as PERHOST in DB. They are active but not downloaded to the secondary storages and hence no template-zone entry. Skips the template-zone check for such templates. Fixes apache#5265 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

shwstppr · Aug 3, 2021

@blueorangutan package

blueorangutan · Aug 3, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Aug 3, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 741

GabrielBrascher

Code LGTM.

shwstppr · Aug 3, 2021

cmk output added for tests using VMware env attaching vmware-tools ISO to a VM

shwstppr · Aug 3, 2021

@blueorangutan test

blueorangutan · Aug 3, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland

clgtm

blueorangutan · Aug 4, 2021

Trillian test result (tid-1465)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41668 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1465-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Failure`	303.60	test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	522.54	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	480.58	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3787.30	test_vpc_redundant.py

weizhouapache · Aug 4, 2021

tested ok.
I merged this pr into #5258 , and confirmed the ISO vmware-tools.iso can be attached to vm.

sureshanaparti

clgtm

sureshanaparti · Aug 4, 2021

@blueorangutan test matrix

blueorangutan · Aug 4, 2021

@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · Aug 4, 2021

Trillian test result (tid-1476)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41616 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1476-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	82.16	test_kubernetes_clusters.py

blueorangutan · Aug 5, 2021

Trillian test result (tid-1475)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1475-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 83 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	833.59	test_internal_lb.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	519.93	test_privategw_acl.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	575.62	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	496.64	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	495.68	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	532.75	test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	1514.41	test_host_maintenance.py

davidjumani

Verified, able to mount vmware-tools.iso and xs-tools.iso

blueorangutan · Aug 5, 2021

Trillian test result (tid-1477)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 67163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1477-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_disk_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 71 look OK, 16 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAddVmToSubDomain>:setup	`Error`	2762.37	test_accounts.py
test_DeleteDomain	`Error`	3611.34	test_accounts.py
test_DeleteDomain	`Error`	3617.03	test_accounts.py
test_forceDeleteDomain	`Failure`	3608.59	test_accounts.py
test_forceDeleteDomain	`Error`	3616.12	test_accounts.py
test_01_user_remove_VM_running	`Error`	3606.02	test_accounts.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	2.25	test_affinity_groups_projects.py
test_DeployVmAffinityGroup	`Error`	1.21	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	1.13	test_affinity_groups.py
test_query_async_job_result	`Error`	2.64	test_async_job.py
test_3d_gpu_support	`Error`	17.02	test_deploy_vgpu_enabled_vm.py
test_05_deploy_vm_with_extraconfig_vmware	`Error`	1.18	test_deploy_vm_extra_config_data.py
test_deploy_vm_from_iso	`Error`	6.63	test_deploy_vm_iso.py
test_00_deploy_vm_root_resize	`Error`	1.20	test_deploy_vm_root_resize.py
test_deployvm_firstfit	`Error`	1.23	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	1.17	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing	`Error`	1.16	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata	`Error`	1.25	test_deploy_vm_with_userdata.py
test_deployvm_userdata_post	`Error`	1.27	test_deploy_vm_with_userdata.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
test_03_deploy_vm_domain_service_offering	`Error`	1.94	test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering	`Error`	4.00	test_domain_vpc_offerings.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Error`	422.86	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Error`	222.32	test_internal_lb.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	600.29	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	641.32	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	531.61	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	564.67	test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	5.44	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Failure`	3.45	test_host_maintenance.py

server/src/main/java/com/cloud/template/TemplateManagerImpl.java

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · Aug 6, 2021

@blueorangutan package

blueorangutan · Aug 6, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Aug 6, 2021

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian. SL-JID 780

nvazquez

Code LGTM

nvazquez · Aug 6, 2021

@blueorangutan package

blueorangutan · Aug 6, 2021

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Aug 6, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 787

nvazquez · Aug 7, 2021

@blueorangutan test matrix

blueorangutan · Aug 7, 2021

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · Aug 7, 2021

Trillian Build Failed (tid-1522)

blueorangutan · Aug 7, 2021

Trillian test result (tid-1523)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34812 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1523-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · Aug 7, 2021

Trillian test result (tid-1524)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38195 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1524-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Smoke tests completed. 84 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	93.93	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	47.73	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	38.09	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py

shwstppr · Aug 8, 2021

@blueorangutan test centos7 xenserver-71

blueorangutan · Aug 8, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

blueorangutan · Aug 9, 2021

Trillian test result (tid-1536)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46483 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5270-t1536-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	355.93	test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	591.78	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	582.99	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	501.56	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	538.73	test_vpc_redundant.py

apache deleted a comment from blueorangutan Aug 3, 2021

shwstppr changed the base branch from main to 4.15 August 3, 2021 07:50

yadvr requested review from davidjumani, nvazquez, sureshanaparti and weizhouapache August 3, 2021 09:04

shwstppr closed this Aug 3, 2021

shwstppr reopened this Aug 3, 2021

DaanHoogland reviewed Aug 3, 2021

View reviewed changes

server/src/main/java/com/cloud/template/TemplateManagerImpl.java Outdated Show resolved Hide resolved

inverted check

b52cf7e

apache deleted a comment from blueorangutan Aug 3, 2021

GabrielBrascher approved these changes Aug 3, 2021

View reviewed changes

DaanHoogland approved these changes Aug 4, 2021

View reviewed changes

weizhouapache approved these changes Aug 4, 2021

View reviewed changes

sureshanaparti approved these changes Aug 4, 2021

View reviewed changes

davidjumani approved these changes Aug 5, 2021

View reviewed changes

DaanHoogland added this to the 4.15.2.0 milestone Aug 5, 2021

DaanHoogland added component:vmware component:XenServer type:bug labels Aug 5, 2021

nvazquez reviewed Aug 6, 2021

View reviewed changes

server/src/main/java/com/cloud/template/TemplateManagerImpl.java Outdated Show resolved Hide resolved

use constants in TemplateManager

9a04bb6

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

nvazquez approved these changes Aug 6, 2021

View reviewed changes

apache deleted a comment from blueorangutan Aug 8, 2021

yadvr merged commit 1ccb420 into apache:4.15 Aug 9, 2021

yadvr mentioned this pull request Aug 9, 2021

Mounting ISO with VMware tools fails #5265

Closed

Search code, repositories, users, issues, pull requests...

Conversation

shwstppr commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

shwstppr commented Aug 3, 2021

Uh oh!

blueorangutan commented Aug 3, 2021

Uh oh!

blueorangutan commented Aug 3, 2021

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Aug 3, 2021

Uh oh!

shwstppr commented Aug 3, 2021

Uh oh!

blueorangutan commented Aug 3, 2021

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

weizhouapache commented Aug 4, 2021

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 4, 2021

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

davidjumani left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 5, 2021

Uh oh!

Uh oh!

shwstppr commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

blueorangutan commented Aug 6, 2021

Uh oh!

nvazquez commented Aug 7, 2021

Uh oh!

blueorangutan commented Aug 7, 2021

Uh oh!

blueorangutan commented Aug 7, 2021

Uh oh!

blueorangutan commented Aug 7, 2021

Uh oh!

blueorangutan commented Aug 7, 2021

Uh oh!

shwstppr commented Aug 8, 2021

Uh oh!

blueorangutan commented Aug 8, 2021

shwstppr commented Aug 3, 2021 •

edited

Loading