Using Profiler class, from the utils package, instead of System.currentTimeMillis()#525
Closed
wilderrodrigues wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom
schubergphilis:fix/no_sys_timemillis_IICopy head branch name to clipboard
Closed
Using Profiler class, from the utils package, instead of System.currentTimeMillis()#525wilderrodrigues wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom schubergphilis:fix/no_sys_timemillis_IICopy head branch name to clipboard
wilderrodrigues wants to merge 2 commits intoapache:masterapache/cloudstack:masterfrom
schubergphilis:fix/no_sys_timemillis_IICopy head branch name to clipboard
Conversation
- Splitting format commit from fix commit.
Contributor
|
this is not just more consistent but also more accurate timing as the time calculation is not done in a string concatenation. LGTM |
|
cloudstack-pull-requests #649 SUCCESS |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
In legacy UI, we display the url of the template to admins. Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class ClusterServiceServletImpl was using System.currentTimeMillis() in order to measure a method execution time . We have a Profiler class, under the com.cloud.utils package, so I'm trying to make the use of that class consistent.
The PR is split in 2 commits: one for the formatting changes; and the other for applying the Profiler usage.