Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ui: Replace bulk delete icons#5222

Merged
DaanHoogland merged 1 commit intoapache:mainapache/cloudstack:mainfrom
shapeblue:fix-bulk-iconsshapeblue/cloudstack:fix-bulk-iconsCopy head branch name to clipboard
Jul 21, 2021
Merged

ui: Replace bulk delete icons#5222
DaanHoogland merged 1 commit intoapache:mainapache/cloudstack:mainfrom
shapeblue:fix-bulk-iconsshapeblue/cloudstack:fix-bulk-iconsCopy head branch name to clipboard

Conversation

@davidjumani
Copy link
Contributor

Description

Uses the appropriate icon for delete

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Amongst others :
Screenshot from 2021-07-20 11-07-50

@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani davidjumani added this to the 4.16.0.0 milestone Jul 20, 2021
@davidjumani
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5222 (SL-JID-397)

@davidjumani davidjumani requested a review from utchoang July 21, 2021 05:07
Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DaanHoogland DaanHoogland merged commit 61de489 into apache:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.