Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "Externalize kvm agent storage timeout configuration"#5218

Merged
DaanHoogland merged 1 commit intomainapache/cloudstack:mainfrom
revert-4585-externalize-kvm-agent-storage-timeout-configurationapache/cloudstack:revert-4585-externalize-kvm-agent-storage-timeout-configurationCopy head branch name to clipboard
Jul 20, 2021
Merged

Revert "Externalize kvm agent storage timeout configuration"#5218
DaanHoogland merged 1 commit intomainapache/cloudstack:mainfrom
revert-4585-externalize-kvm-agent-storage-timeout-configurationapache/cloudstack:revert-4585-externalize-kvm-agent-storage-timeout-configurationCopy head branch name to clipboard

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Jul 19, 2021

Reverts #4585

this has been tested locally, #4585 introduced a regression where KVM hosts could not be added to a zone. It was not found in older smoke tests setups, so probably introduced in combination with some other PR that got merged between the smoketest run and the merge of #4585.

@nvazquez
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 590

@nvazquez
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1319)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5218-t1319-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @GutoVeronezi also agreed to revert PR#4585 now. So LGTM

@yadvr
Copy link
Member

yadvr commented Jul 20, 2021

Lgtm

@DaanHoogland DaanHoogland merged commit 6f93e5c into main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.