Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove condition that are prevent resizing for root volumes (vmware)#5186

Merged
nvazquez merged 3 commits intoapache:mainapache/cloudstack:mainfrom
NDBSGMS:feat/resize_root_volumes_vmwareNDBSGMS/cloudstack:feat/resize_root_volumes_vmwareCopy head branch name to clipboard
Jul 22, 2021
Merged

Remove condition that are prevent resizing for root volumes (vmware)#5186
nvazquez merged 3 commits intoapache:mainapache/cloudstack:mainfrom
NDBSGMS:feat/resize_root_volumes_vmwareNDBSGMS/cloudstack:feat/resize_root_volumes_vmwareCopy head branch name to clipboard

Conversation

@DK101010
Copy link
Contributor

@DK101010 DK101010 commented Jul 6, 2021

Description

Remove condition that are prevent resizing for root volumes (vmware).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested in own VMware Environment. Works without errors and root disk is correct resized

@mib1185
Copy link
Contributor

mib1185 commented Jul 6, 2021

@blueorangutan test centos7 vmware-65u2

@shwstppr
Copy link
Contributor

shwstppr commented Jul 6, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 6, 2021

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 6, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 482

@shwstppr
Copy link
Contributor

shwstppr commented Jul 6, 2021

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link

blueorangutan commented Jul 6, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 7, 2021

Trillian test result (tid-1211)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49349 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5186-t1211-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_vpc_privategw_restart_vpc_cleanup Failure 640.21 test_privategw_acl.py
test_01_migrate_VM_and_root_volume Error 107.94 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 87.82 test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 641.99 test_vpc_redundant.py

@mib1185
Copy link
Contributor

mib1185 commented Jul 9, 2021

@shwstppr I guess that these error are not related to changes from this PR 🤔

@shwstppr
Copy link
Contributor

shwstppr commented Jul 9, 2021

@mib1185 yes they don't seem to be related. Moreover, 2nd and 3rd failure in that list should be fixed by #5170

@mib1185
Copy link
Contributor

mib1185 commented Jul 11, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

@mib1185 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 514

@mib1185
Copy link
Contributor

mib1185 commented Jul 11, 2021

@blueorangutan test centos7 vmware-65u2

@mib1185
Copy link
Contributor

mib1185 commented Jul 11, 2021

@blueorangutan help

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

@mib1185 I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos7', 'centos6', 'alma8', 'ubuntu18', 'suse15', 'ubuntu20', 'rocky8', 'centos8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache']

@shwstppr
Copy link
Contributor

shwstppr commented Jul 11, 2021

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link

blueorangutan commented Jul 11, 2021

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 13, 2021

Trillian test result (tid-1227)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 110673 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5186-t1227-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Smoke tests completed. 61 look OK, 27 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestInternalLb>:setup Error 0.00 test_internal_lb.py
ContextSuite context=TestAccounts>:setup Error 0.00 test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup Error 0.00 test_accounts.py
test_DeleteDomain Error 4.10 test_accounts.py
test_forceDeleteDomain Failure 4.07 test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup Error 5.06 test_accounts.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup Error 0.00 test_affinity_groups_projects.py
ContextSuite context=TestAsyncJob>:setup Error 0.00 test_async_job.py
test_01_create_iso_with_checksum_sha1 Error 66.37 test_iso.py
test_02_create_iso_with_checksum_sha256 Error 66.39 test_iso.py
test_03_create_iso_with_checksum_md5 Error 66.38 test_iso.py
test_04_create_iso_with_no_checksum Error 66.37 test_iso.py
test_01_create_iso Failure 1512.05 test_iso.py
ContextSuite context=TestISO>:setup Error 3023.05 test_iso.py
ContextSuite context=TestLoadBalance>:setup Error 0.00 test_loadbalance.py
test_3d_gpu_support Error 1512.14 test_deploy_vgpu_enabled_vm.py
ContextSuite context=TestDeployVMFromISO>:setup Error 0.00 test_deploy_vm_iso.py
test_list_clusters_metrics Error 1511.63 test_metrics_api.py
test_list_vms_metrics Error 0.15 test_metrics_api.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup Error 0.00 test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup Error 0.00 test_deploy_vm_with_userdata.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
ContextSuite context=TestRemoteDiagnostics>:setup Error 0.00 test_diagnostics.py
test_delete_account Error 1511.43 test_network.py
test_delete_network_while_vm_on_it Error 1.11 test_network.py
test_deploy_vm_l2network Error 1.10 test_network.py
test_l2network_restart Error 2.25 test_network.py
ContextSuite context=TestPortForwarding>:setup Error 3.39 test_network.py
ContextSuite context=TestPublicIP>:setup Error 1.04 test_network.py
test_reboot_router Failure 0.04 test_network.py
test_releaseIP Error 0.44 test_network.py
ContextSuite context=TestRouterRules>:setup Error 0.51 test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup Error 0.00 test_nic_adapter_type.py
ContextSuite context=TestDomainsServiceOfferings>:setup Error 1514.66 test_domain_service_offerings.py
test_01_invalid_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_02_deploy_and_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
test_nic_secondaryip_add_remove Error 1511.61 test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup Error 0.00 test_nested_virtualization.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup Error 1518.28 test_projects.py
test_01_migrate_VM_and_root_volume Error 114.15 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 100.00 test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots Failure 906.21 test_vm_snapshots.py
test_01_VPC_nics_after_destroy Failure 994.10 test_vpc_router_nics.py

@Pearl1594
Copy link
Contributor

Pearl1594 commented Jul 14, 2021

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 14, 2021

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 14, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 543

@Pearl1594
Copy link
Contributor

Pearl1594 commented Jul 14, 2021

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link

blueorangutan commented Jul 14, 2021

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 15, 2021

Trillian test result (tid-1269)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 92156 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5186-t1269-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 78 look OK, 10 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti added this to the 4.16.0.0 milestone Jul 16, 2021
@nvazquez
Copy link
Contributor

nvazquez commented Jul 20, 2021

@davidjumani can you please test this PR?

@nvazquez nvazquez mentioned this pull request Jul 21, 2021
Closed
davidjumani
davidjumani approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to resize the root volume on a running VM with rootDiskController=scsi

@nvazquez
Copy link
Contributor

nvazquez commented Jul 21, 2021

Thanks @davidjumani
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2021

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2021

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 617

@nvazquez
Copy link
Contributor

nvazquez commented Jul 21, 2021

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2021

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 21, 2021

Trillian test result (tid-1339)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40126 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5186-t1339-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez merged commit c23cbdf into apache:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

@davidjumani davidjumani davidjumani approved these changes

Assignees

No one assigned

Labels

component:vmware type:new-feature

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@DK101010 @mib1185 @shwstppr @blueorangutan @Pearl1594 @nvazquez @DaanHoogland @davidjumani @sureshanaparti
Morty Proxy This is a proxified and sanitized view of the page, visit original site.