Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach…#510

Closed
resmo wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
resmo:fix/CLOUDSTACK-8578Copy head branch name to clipboard
Closed

CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach…#510
resmo wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
resmo:fix/CLOUDSTACK-8578Copy head branch name to clipboard

Conversation

@resmo
Copy link
Member

@resmo resmo commented Jun 23, 2015

…ines when zone is specified

@asfbot
Copy link

asfbot commented Jun 23, 2015

cloudstack-pull-requests #630 SUCCESS
This pull request looks good

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 23, 2015

why should we return machines that no longer exist?

@resmo
Copy link
Member Author

resmo commented Jun 23, 2015

@DaanHoogland We already do :). User permissions API is not affected of this change however.

The API does already return VMs listVirtualMachines in destroyed state if you have admin permissions.

But if you provide zoneid in listVirtualMachines with admin permissions, it does not return VMs in destroyed state. This makes no sense to me. The bug was already fixed in CLOUDSTACK-284 but then the bug was reimplemented by accident.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jun 23, 2015

good point so backwards compatibility is a glass eye anyway;) will merge

@asfgit asfgit closed this in 82ecc1a Jun 23, 2015
@resmo resmo deleted the fix/CLOUDSTACK-8578 branch June 23, 2015 12:53
@yadvr
Copy link
Member

yadvr commented Jun 23, 2015

this can potentially break clients depending on the behaviour when zoneid is passed

@yadvr
Copy link
Member

yadvr commented Jun 23, 2015

@resmo can you send a doc PR so at least we can document this in release notes?

@resmo
Copy link
Member Author

resmo commented Jun 23, 2015

@bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. present which returns all VMs in states `starting, running, stopped, stopping'. So the old behaviour could be used as well in a proper way. Any thoughts?

@resmo resmo mentioned this pull request Jun 23, 2015
Closed
kishankavala pushed a commit to kishankavala/cloudstack that referenced this pull request Jun 25, 2015
@resmo @kishankavala
CLOUDSTACK-8578: fix listVirtualMachines does not return deleted mach…
2ef1c40 
…ines when zone is specified

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes apache#510
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 27, 2025
@DaanHoogland @GutoVeronezi
Verify QCOW2 features on direct download of template (apache#510)
90c320e 
Co-authored-by: Daniel Augusto Veronezi Salvador <gutoveronezi@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@resmo @asfbot @DaanHoogland @yadvr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.