UI: Add multiple management server support by utchoang · Pull Request #4885 · apache/cloudstack

utchoang · Apr 1, 2021

Description

Related apache/cloudstack-primate#898
This PR for Add multiple management server support

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

davidjumani · Jun 1, 2021

Think it would be good to show the management server to which the user is connected listed in the header next to his name. Thoughts @utchoang @rhtyd

yadvr · Jun 9, 2021

@blueorangutan ui

blueorangutan · Jun 9, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · Jun 9, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4885 (SL-JID-229)

ui/src/components/header/UserMenu.vue

davidjumani · Jun 22, 2021

@utchoang Did you face any CORS issue ?

utchoang · Jun 22, 2021

@davidjumani In the previous discussion at apache/cloudstack-primate#898 there was a discussion about the CORS issue, and I think it will be solved by Nginx proxy. I think so.

utchoang · Jun 22, 2021

@blueorangutan ui

blueorangutan · Jun 22, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · Jun 22, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4885 (SL-JID-273)

wido · Jun 22, 2021

@davidjumani In the previous discussion at apache/cloudstack-primate#898 there was a discussion about the CORS issue, and I think it will be solved by Nginx proxy. I think so.

Indeed. As long as a proxy in between is used to use URLs and not different domains for management servers CORS is not an issue, for example:

/proxy/management-server-1
/proxy/management-server-2
/proxy/management-server-3

These would be the relative URLs to reach the different management servers.

This means that you do not set apiHost, but only set apiBase for each Management Server.

Otherwise you need to deal with CORS indeed and thus add headers which can be done by Nginx/Apache.

wido

LGTM

weizhouapache · Jun 22, 2021

I have tested apache/cloudstack-primate#898, which worked.
I used nginx or pfsense/haproxy to solve CORS issue.

@utchoang are these two prs same ?

utchoang · Jun 22, 2021

@weizhouapache Yes. Two PRs same.

weizhouapache

@utchoang great. lgtm

ui/src/components/widgets/Console.vue

davidjumani · Jun 22, 2021

@davidjumani In the previous discussion at apache/cloudstack-primate#898 there was a discussion about the CORS issue, and I think it will be solved by Nginx proxy. I think so.

Indeed. As long as a proxy in between is used to use URLs and not different domains for management servers CORS is not an issue, for example:
* /proxy/management-server-1

* /proxy/management-server-2

* /proxy/management-server-3
These would be the relative URLs to reach the different management servers.

This means that you do not set apiHost, but only set apiBase for each Management Server.

Otherwise you need to deal with CORS indeed and thus add headers which can be done by Nginx/Apache.

Thanks, was playing around in dev mode but got it working

GabrielBrascher

LGTM

nvazquez · Jul 12, 2021

LGTM
@utchoang there is only one open comment, can you please check?

DaanHoogland · Jul 13, 2021

enough lgtm, but has this been tested? (@davidjumani ?)

yadvr · Jul 15, 2021

@utchoang can you send some doc PR on how users will use it; for example how to configure the reverse proxy/server etc and will the dropdown be hidden for most users, say who don't want to specify or use this feature?

…servers or not

davidjumani · Aug 9, 2021

@DaanHoogland This has been tested and working. For anyone who needs to test it locally,

Update ui/public/config.json

  "servers": [
    {
      "name": "QA-Server",
      "apiHost": "",
      "apiBase": "/qa/api"
    },
    {
      "name": "Localhost",
      "apiHost": "",
      "apiBase": "/client/api"
    }
  ],

Update ui/vue.config.js

proxy: {
      '/qa': {
        target: 'http://qa.cloudstack.cloud:8080/',
        secure: false,
        ws: false,
        pathRewrite: {
          '/qa/api': '/client/api',
          '/qa/console': '/console'
        },
        cookiePathRewrite: {
          '/qa/api': '/client/api',
          '*': '/'
        },
        changeOrigin: true,
        proxyTimeout: 10 * 60 * 1000 // 10 minutes
      },
      '/client': {
        target: process.env.CS_URL || 'http://localhost:8080',
        secure: false,
        ws: false,
        changeOrigin: true,
        proxyTimeout: 10 * 60 * 1000 // 10 minutes
      }
    }

yadvr · Aug 9, 2021

@blueorangutan ui

blueorangutan · Aug 9, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

yadvr · Aug 9, 2021

ui/public/config.json

@@ -1,5 +1,12 @@
 {
  "apiBase": "/client/api",
+  "servers": [


I think this feature shouldn't be enabled by default, wouldn't it confuse users/admins? @utchoang @davidjumani @wido @nvazquez @sureshanaparti @weizhouapache @Pearl1594 @shwstppr ?

If the list only shows one server at the time, what would it confuse them? There is only one option to select

@rhtyd Yes. I will set it to default hidden mode. If the user/admin wants to enable it, the configuration can be changed.

Looks good with @utchoang's change, disabled by default. +1 for getting this in asap

+1
thanks @utchoang

blueorangutan · Aug 9, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4885 (SL-JID-495)

davidjumani · Aug 10, 2021

@blueorangutan ui

blueorangutan · Aug 10, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · Aug 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4885 (SL-JID-500)

nvazquez

LGTM

nvazquez · Aug 11, 2021

Merging based on approvals

add multiple management server support

500c946

utchoang changed the title ~~add multiple management server support~~ UI: Add multiple management server support Apr 1, 2021

utchoang mentioned this pull request Apr 1, 2021

Check and fix all UI issue from the archived primate repository #4726

Closed

yadvr added this to the 4.16.0.0 milestone Apr 4, 2021

Merge branch '4.15' into feature/multiple-server

e3a9d47

yadvr requested review from GabrielBrascher, Pearl1594, davidjumani, wido and yadvr May 25, 2021 13:55

utchoang added 2 commits June 7, 2021 13:19

Merge branch '4.15' into feature/multiple-server

beb16d7

display the server on the user menu

11b1c87

davidjumani reviewed Jun 22, 2021

View reviewed changes

ui/src/components/header/UserMenu.vue Outdated Show resolved Hide resolved

remove primary color in server icon

baaec38

wido approved these changes Jun 22, 2021

View reviewed changes

weizhouapache approved these changes Jun 22, 2021

View reviewed changes

davidjumani reviewed Jun 22, 2021

View reviewed changes

ui/src/components/widgets/Console.vue Outdated Show resolved Hide resolved

sureshanaparti added the component:UI label Jun 27, 2021

GabrielBrascher approved these changes Jul 7, 2021

View reviewed changes

utchoang added 2 commits July 13, 2021 08:28

Merge branch '4.15' into feature/multiple-server

7201df0

using /client from apiBase

a3bf6eb

davidjumani approved these changes Jul 13, 2021

View reviewed changes

add a setting that allows users to customize whether to use multiple …

f29e0b9

…servers or not

This was referenced Jul 27, 2021

[DOCCUMENT] - UI - Multiple management server support #5244

Closed

ui - Multiple server management documentation apache/cloudstack-documentation#232

Merged

yadvr reviewed Aug 9, 2021

View reviewed changes

set default hidden the multiple server config

3242383

davidjumani approved these changes Aug 10, 2021

View reviewed changes

nvazquez approved these changes Aug 11, 2021

View reviewed changes

nvazquez merged commit 1182051 into apache:4.15 Aug 11, 2021

utchoang deleted the feature/multiple-server branch August 16, 2021 00:56

Search code, repositories, users, issues, pull requests...

Conversation

utchoang commented Apr 1, 2021

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

davidjumani commented Jun 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Jun 9, 2021

Uh oh!

blueorangutan commented Jun 9, 2021

Uh oh!

blueorangutan commented Jun 9, 2021

Uh oh!

Uh oh!

davidjumani commented Jun 22, 2021

Uh oh!

utchoang commented Jun 22, 2021

Uh oh!

utchoang commented Jun 22, 2021

Uh oh!

blueorangutan commented Jun 22, 2021

Uh oh!

blueorangutan commented Jun 22, 2021

Uh oh!

wido commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jun 22, 2021

Uh oh!

utchoang commented Jun 22, 2021

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidjumani commented Jun 22, 2021

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jul 12, 2021

Uh oh!

DaanHoogland commented Jul 13, 2021

Uh oh!

yadvr commented Jul 15, 2021

Uh oh!

davidjumani commented Aug 9, 2021

Uh oh!

yadvr commented Aug 9, 2021

Uh oh!

blueorangutan commented Aug 9, 2021

Uh oh!

yadvr Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

wido Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

utchoang Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

davidjumani Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

nvazquez Aug 11, 2021

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 9, 2021

Uh oh!

davidjumani commented Aug 10, 2021

davidjumani commented Jun 1, 2021 •

edited

Loading

wido commented Jun 22, 2021 •

edited

Loading