Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

UI: Moves fetchdata() to the created()#4811

Merged
yadvr merged 6 commits intoapache:4.15apache/cloudstack:4.15from
utchoang:feature/move-fetchdata-createdutchoang/cloudstack:feature/move-fetchdata-createdCopy head branch name to clipboard
Apr 5, 2021
Merged

UI: Moves fetchdata() to the created()#4811
yadvr merged 6 commits intoapache:4.15apache/cloudstack:4.15from
utchoang:feature/move-fetchdata-createdutchoang/cloudstack:feature/move-fetchdata-createdCopy head branch name to clipboard

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 15, 2021 •
edited
Loading

Description

This PR to move fetchData() to created() insteadof mount()

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang utchoang mentioned this pull request Mar 15, 2021
Merged
12 tasks
@utchoang utchoang marked this pull request as ready for review March 15, 2021 06:09
@utchoang
Copy link
Author

utchoang commented Mar 15, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 15, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@utchoang utchoang requested review from shwstppr and yadvr March 15, 2021 06:34
@shwstppr
Copy link
Contributor

shwstppr commented Mar 15, 2021

@utchoang will this offer any performance improvement? I hope we are not accessing/manipulating DOM elements in any of the fetchData methods

@utchoang
Copy link
Author

utchoang commented Mar 15, 2021

@shwstppr Yes. In apache/cloudstack-primate#719 then move fetchData to created from mounted to reduce wait time for API calls since the data has been created but the page has not yet been rendered

@DaanHoogland DaanHoogland added this to the 4.15.1.0 milestone Mar 15, 2021
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@yadvr
Copy link
Member

yadvr commented Mar 22, 2021

@utchoang what are the pros and cons of using one vs the other?

@utchoang
Copy link
Author

utchoang commented Mar 22, 2021

@rhtyd When the component is initialized, fetching data from the backend at created() will be done without having to wait for the DOM to be mounted or rendered as if it were called on mounted().

davidjumani
davidjumani reviewed Mar 24, 2021
View reviewed changes
ui/src/views/infra/network/EditTrafficLabel.vue Show resolved Hide resolved
davidjumani
davidjumani reviewed Mar 24, 2021
View reviewed changes
ui/src/views/offering/ImportBackupOffering.vue Show resolved Hide resolved
@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-63)

davidjumani
davidjumani approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did a quick round of testing
Forms appear to load a bit sooner

@yadvr
Copy link
Member

yadvr commented Mar 29, 2021

@utchoang can you fix the conflict against latest 4.15 branch

@yadvr
Copy link
Member

yadvr commented Apr 1, 2021

@utchoang can you fix the conflict?

@yadvr
Copy link
Member

yadvr commented Apr 5, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

yadvr
yadvr approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM proxing David's testing/review

@yadvr yadvr merged commit 4dcd9a2 into apache:4.15 Apr 5, 2021
@blueorangutan
Copy link

blueorangutan commented Apr 5, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-88)

@utchoang utchoang deleted the feature/move-fetchdata-created branch April 5, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@davidjumani davidjumani davidjumani approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

Labels

component:UI type:cleanup

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@utchoang @blueorangutan @shwstppr @yadvr @davidjumani @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.