test: fix listVolumes call for detach volume migration check#4785
Merged
yadvr merged 1 commit intoapache:4.14apache/cloudstack:4.14from Mar 11, 2021
shapeblue:fix-vm-test-detachvolshapeblue/cloudstack:fix-vm-test-detachvolCopy head branch name to clipboard
Merged
test: fix listVolumes call for detach volume migration check#4785yadvr merged 1 commit intoapache:4.14apache/cloudstack:4.14from shapeblue:fix-vm-test-detachvolshapeblue/cloudstack:fix-vm-test-detachvolCopy head branch name to clipboard
yadvr merged 1 commit intoapache:4.14apache/cloudstack:4.14from
shapeblue:fix-vm-test-detachvolshapeblue/cloudstack:fix-vm-test-detachvolCopy head branch name to clipboard
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
12 tasks
yadvr
approved these changes
Mar 11, 2021
Member
yadvr
left a comment
There was a problem hiding this comment.
LGTM change is strictly in test which is validated by Travis. There's no volume parameter in listVolumes API.
nlgordon
pushed a commit
to ippathways/cloudstack
that referenced
this pull request
Aug 2, 2022
…4785) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the wrong parameter while using listVolumes API after detached volume migration.
Current code uses an invalid
volumeparameter which leads to test failure in cases when there are other volumes in different pools.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?