Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

UI: Submit the form when press CTRL + ENTER#4766

Merged
nvazquez merged 30 commits intoapache:mainapache/cloudstack:mainfrom
utchoang:feature/enter-submit-formutchoang/cloudstack:feature/enter-submit-formCopy head branch name to clipboard
Jul 26, 2021
Merged

UI: Submit the form when press CTRL + ENTER#4766
nvazquez merged 30 commits intoapache:mainapache/cloudstack:mainfrom
utchoang:feature/enter-submit-formutchoang/cloudstack:feature/enter-submit-formCopy head branch name to clipboard

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 8, 2021 •
edited
Loading

Description

This PR for fixes submit the form when pressing Enter

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang utchoang mentioned this pull request Mar 8, 2021
Merged
12 tasks
@utchoang
Copy link
Author

utchoang commented Mar 8, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (JID-3855)

@utchoang utchoang marked this pull request as draft March 9, 2021 01:56
@utchoang utchoang marked this pull request as ready for review March 11, 2021 09:03
@utchoang utchoang requested review from shwstppr and yadvr March 15, 2021 06:07
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@yadvr yadvr added this to the 4.15.1.0 milestone Mar 17, 2021
@yadvr
Copy link
Member

yadvr commented Mar 18, 2021

Could this break anything? (for example in any input that is textarea of multi-line) cc @shwstppr @Pearl1594 @borisstoyanov @vladimirpetrov @andrijapanicsb

@utchoang
Copy link
Author

utchoang commented Mar 18, 2021

@rhtyd Yes, currently for textarea, selectbox focus the press enter will not submit the form

@andrijapanicsb
Copy link
Contributor

andrijapanicsb commented Mar 18, 2021

Industry practice, from what I've seen is to use CTRL + ENTER to submit a form (i.e. in gmail to send email, in Jira to send comment, in Outlook to send email, etc)

simple ENTER sounds a bit "dangerous"

@andrijapanicsb
Copy link
Contributor

andrijapanicsb commented Mar 18, 2021

and GitHub also uses CTRL + ENTER to send THIS COMMENT :)

@utchoang utchoang changed the title UI: Submit the form when press enter UI: Submit the form when press CTRL + ENTER Mar 19, 2021
@apache apache deleted a comment from blueorangutan Mar 19, 2021
@apache apache deleted a comment from blueorangutan Mar 19, 2021
@utchoang
Copy link
Author

utchoang commented Mar 19, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 19, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link

blueorangutan commented Mar 19, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-40)

@utchoang
Copy link
Author

utchoang commented Mar 19, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 19, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

davidjumani
davidjumani reviewed Jul 26, 2021
View reviewed changes
ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue Outdated Show resolved Hide resolved
@utchoang
Copy link
Author

utchoang commented Jul 26, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-423)

davidjumani
davidjumani reviewed Jul 26, 2021
View reviewed changes
ui/src/views/project/InvitationTokenTemplate.vue Outdated Show resolved Hide resolved
davidjumani
davidjumani reviewed Jul 26, 2021
View reviewed changes
ui/src/views/network/InternalLBAssignVmForm.vue Show resolved Hide resolved
davidjumani
davidjumani reviewed Jul 26, 2021
View reviewed changes
ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue Outdated Show resolved Hide resolved
@utchoang
Copy link
Author

utchoang commented Jul 26, 2021

@davidjumani can you check it again? Thanks.

@utchoang
Copy link
Author

utchoang commented Jul 26, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-424)

davidjumani
davidjumani reviewed Jul 26, 2021
View reviewed changes
ui/src/utils/directives.js Show resolved Hide resolved
@davidjumani
Copy link
Contributor

davidjumani commented Jul 26, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@davidjumani
Copy link
Contributor

davidjumani commented Jul 26, 2021

@utchoang Facing the issue mentioned in #4766 (comment) again, perhaps something changed in a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-425)

@utchoang
Copy link
Author

utchoang commented Jul 26, 2021

@davidjumani

@utchoang Facing the issue mentioned in #4766 (comment) again, perhaps something changed in a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

sorry I forgot this on Firefox, I'll fix it now

@davidjumani
Copy link
Contributor

davidjumani commented Jul 26, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 26, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-426)

davidjumani
davidjumani approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @utchoang

nvazquez
nvazquez approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 8efc3ea into apache:main Jul 26, 2021
@utchoang utchoang deleted the feature/enter-submit-form branch July 27, 2021 00:34
@davidjumani
Copy link
Contributor

davidjumani commented Aug 9, 2021

@utchoang I'm getting these errors at times (now while trying to add a firewall rule) by pressing control-enter. Can you please check
Screenshot from 2021-08-09 15-35-58

@utchoang utchoang mentioned this pull request Aug 10, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@davidjumani davidjumani davidjumani approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@yadvr yadvr Awaiting requested review from yadvr

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

@Pearl1594 Pearl1594

Labels

component:UI type:new-feature

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@utchoang @blueorangutan @yadvr @andrijapanicsb @davidjumani @Pearl1594 @DaanHoogland @nvazquez
Morty Proxy This is a proxified and sanitized view of the page, visit original site.