Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

UI: Fix create zone wizard on mobile view#4764

Merged
yadvr merged 3 commits intoapache:4.15apache/cloudstack:4.15from
utchoang:feature/create-zone-mobile-viewutchoang/cloudstack:feature/create-zone-mobile-viewCopy head branch name to clipboard
Mar 30, 2021
Merged

UI: Fix create zone wizard on mobile view#4764
yadvr merged 3 commits intoapache:4.15apache/cloudstack:4.15from
utchoang:feature/create-zone-mobile-viewutchoang/cloudstack:feature/create-zone-mobile-viewCopy head branch name to clipboard

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 8, 2021 •
edited
Loading

Description

This PR for fixes create zone form in mobile view

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After fixed:
imageimage

How Has This Been Tested?

@utchoang utchoang mentioned this pull request Mar 8, 2021
Merged
12 tasks
@utchoang
Copy link
Author

utchoang commented Mar 8, 2021

@blueorangutan ui

@utchoang utchoang changed the title Feature/create zone mobile view UI: Fix create zone wizard on mobile view Mar 8, 2021
@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (JID-3852)

@utchoang utchoang marked this pull request as draft March 9, 2021 01:57
@utchoang utchoang marked this pull request as ready for review March 11, 2021 08:59
@utchoang utchoang requested review from shwstppr and yadvr March 15, 2021 06:06
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@yadvr yadvr added this to the 4.15.1.0 milestone Mar 17, 2021
@yadvr
Copy link
Member

yadvr commented Mar 24, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (SL-JID-55)

@davidjumani
Copy link
Contributor

davidjumani commented Mar 24, 2021 •
edited
Loading

Will review after #4762 since it has a shared commit

@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@utchoang Could you remove d998f27 and push ? Thanks

@utchoang utchoang closed this Mar 25, 2021
@utchoang utchoang force-pushed the feature/create-zone-mobile-view branch from 3866db1 to 3a82392 Compare March 25, 2021 07:34
@utchoang utchoang reopened this Mar 25, 2021
@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4764 (SL-JID-71)

davidjumani
davidjumani approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine in mobile and desktop mode

@yadvr
Copy link
Member

yadvr commented Mar 29, 2021

@utchoang can you fix the conflict against latest 4.15 branch?

Merge branch '4.15' into feature/create-zone-mobile-view
af38519 
# Conflicts:
#	ui/src/views/infra/zone/IpAddressRangeForm.vue
yadvr
yadvr approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - basing based on David's testing and lgtm

@yadvr yadvr merged commit 5b986be into apache:4.15 Mar 30, 2021
@utchoang utchoang deleted the feature/create-zone-mobile-view branch April 1, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@davidjumani davidjumani davidjumani approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@utchoang @blueorangutan @yadvr @davidjumani
Morty Proxy This is a proxified and sanitized view of the page, visit original site.