Improve logs on KVMHostActivityChecker#4706
Improve logs on KVMHostActivityChecker#4706DaanHoogland merged 2 commits intoapache:masterapache/cloudstack:masterfrom GutoVeronezi:improve-logs-on-kvmhostactivitycheckerGutoVeronezi/cloudstack:improve-logs-on-kvmhostactivitycheckerCopy head branch name to clipboard
Conversation
GabrielBrascher
left a comment
There was a problem hiding this comment.
Overall code looks good; most of the changes regard adding logs while keeping the core behavior of the execution flow.
I would like just to bring another option to enhance the logs: what do you think of adding the host's name combined (or not) with the host ID?
In my opinion, this would make it easier to find the problematic host in a blink of an eye, otherwise, there is the need of checking via DB/API to find which host has the respective ID.
|
pressed enter by accident ^^ |
@GabrielBrascher as you suggested, I added more host information to the log. |
GabrielBrascher
left a comment
There was a problem hiding this comment.
Code LGTM, I did not test it though.
- +1 on log improvements;
- the proposal for changing the HostVO
toString()format LGTM as well.
|
@GabrielBrascher @DaanHoogland is there anything else to do? |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 367 |
|
This one looks ready for merge. Travis and Jenkins's tests have passed and the code has 2 LGTMs. Maybe we can spawn @blueorangutan for testing. |
|
Trillian test result (tid-393)
|
Description
This PR intends to improve logging in the class
KVMHostActivityCheckerto facilitate troubleshooting.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
It has been tested locally on a test lab.