cloudstack-pull-requests #465 SUCCESS
This pull request looks good

Remi Bergsma on dev@cloudstack.apache.org>" <dev@cloudstack.apache.org replies:
Thanks for picking this up!

LGTM, I'll try to test it tomorrow.=20

One comment: I'd propose the setting name to reflect 'out of band'. Now it =
looks like when you migrate a router in ACS it will also reboot.=20

router.reboot.when.outofband.migrated?

Regards, Remi=20

Sent from my iPhone
ur
e
se

We should generate alert when out of band router VM migration is detected. This will help user take appropriate action in those scenarios.

@remibergsma makes sense, will do
@anshul1886 feel free to amend, I do not consider your proposed extension part of this blocker though it makes perfect sense from a functional perspective.

@DaanHoogland thanks for picking it up, btw do you port plan to fix it in 4.5 and master as well?

travis timeout, will ignore again. hoping the pull request builder does better.

@resmo to 4.5 yes, to master no. master has persistant config and routers will respin fully configured there.

@anshul1886 would the following satisfy your needs (had some extra time)

•    } else {
  

•        if (isOutOfBandMigrated(opaque)) {
  

•            final String title = "Router has been migrated out of band: " + vo.getInstanceName();
  

•            final String context =
  

•                    "An out of band migration of router " + vo.getInstanceName() + "(" + vo.getUuid() + ") was detected. No automated action was performed.";
  

•            _alertMgr.sendAlert(AlertManager.AlertType.ALERT_TYPE_DOMAIN_ROUTER, vo.getDataCenterId(), vo.getPodIdToDeployIn(), title, context);
  

•        }
  

Yes.