VPC VR: fix Conflicting device id on private gw nic when restart vpc with cleanup#4512
VPC VR: fix Conflicting device id on private gw nic when restart vpc with cleanup#4512DaanHoogland merged 3 commits intoapache:4.14apache/cloudstack:4.14from ustcweizhou:apache-4.14-fix-vpc-issues-part2ustcweizhou/cloudstack:apache-4.14-fix-vpc-issues-part2Copy head branch name to clipboard
Conversation
|
@weizhouapache is this critical fix wrt 4.15 or can we do in the next release? cc @DaanHoogland @PaulAngus |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
@rhtyd it is better to merge it into 4.15.0.0 |
|
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2454 |
|
@weizhouapache okay I've bumped to critical but let's also hear from @PaulAngus and @DaanHoogland |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2455 |
DaanHoogland
left a comment
There was a problem hiding this comment.
seems like a proper refactor though I'd liked to have seen the code taken out in a separate method. The component tests are fixed as well, let's have these run.
|
@blueorangutan test centos7 kvm-centos7 keepEnv |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@rhtyd @PaulAngus I would put this in and merge forward. testing in an independent env (not @weizhouapache's) advised |
@DaanHoogland this pr does not have any change with iptables rules in VRs. |
|
Trillian test result (tid-3300)
|
|
Trillian test result (tid-3302)
|
|
i ran the test_multiple_subnets_in_isolated_network.py component tests and they passed. I just wanted to conform to the external test party rule for merging , @weizhouapache ; good to go as far as i am concerned. |
Description
Some issues with vpc vr have been fixed in #4484
This PR fixes the last two issues we found in our testing.
We run the the integration tests in test/integration/component/test_multiple_subnets*.py many times (>20) , all are SUCCESSFUL.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?