Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

VPC VR: fix Conflicting device id on private gw nic when restart vpc with cleanup#4512

Merged
DaanHoogland merged 3 commits intoapache:4.14apache/cloudstack:4.14from
ustcweizhou:apache-4.14-fix-vpc-issues-part2ustcweizhou/cloudstack:apache-4.14-fix-vpc-issues-part2Copy head branch name to clipboard
Dec 3, 2020
Merged

VPC VR: fix Conflicting device id on private gw nic when restart vpc with cleanup#4512
DaanHoogland merged 3 commits intoapache:4.14apache/cloudstack:4.14from
ustcweizhou:apache-4.14-fix-vpc-issues-part2ustcweizhou/cloudstack:apache-4.14-fix-vpc-issues-part2Copy head branch name to clipboard

Conversation

@ustcweizhou
Copy link
Contributor

@ustcweizhou ustcweizhou commented Dec 1, 2020

Description

Some issues with vpc vr have been fixed in #4484
This PR fixes the last two issues we found in our testing.

We run the the integration tests in test/integration/component/test_multiple_subnets*.py many times (>20) , all are SUCCESSFUL.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@yadvr yadvr added this to the 4.15.0.0 milestone Dec 2, 2020
@yadvr
Copy link
Member

yadvr commented Dec 2, 2020

@weizhouapache is this critical fix wrt 4.15 or can we do in the next release? cc @DaanHoogland @PaulAngus
@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Contributor

@weizhouapache is this critical fix wrt 4.15 or can we do in the next release? cc @DaanHoogland @PaulAngus
@blueorangutan package

@rhtyd it is better to merge it into 4.15.0.0

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2454

@yadvr
Copy link
Member

yadvr commented Dec 2, 2020

@weizhouapache okay I've bumped to critical but let's also hear from @PaulAngus and @DaanHoogland
@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2455

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a proper refactor though I'd liked to have seen the code taken out in a separate method. The component tests are fixed as well, let's have these run.

@DaanHoogland
Copy link
Contributor

@blueorangutan test centos7 kvm-centos7 keepEnv

@blueorangutan
Copy link

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland
Copy link
Contributor

@rhtyd @PaulAngus I would put this in and merge forward. testing in an independent env (not @weizhouapache's) advised

@weizhouapache
Copy link
Contributor

@rhtyd @PaulAngus I would put this in and merge forward. testing in an independent env (not @weizhouapache's) advised

@DaanHoogland this pr does not have any change with iptables rules in VRs.
if all integration tests pass, it should be good.

@blueorangutan
Copy link

Trillian test result (tid-3300)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30110 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4512-t3300-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

Trillian test result (tid-3302)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31604 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4512-t3302-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Contributor

i ran the test_multiple_subnets_in_isolated_network.py component tests and they passed. I just wanted to conform to the external test party rule for merging , @weizhouapache ; good to go as far as i am concerned.

@DaanHoogland DaanHoogland merged commit 83ae6d7 into apache:4.14 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Severity:Critical Critical bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.