Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[VMware] Full OVF properties support#4235

Closed
nvazquez wants to merge 116 commits intoapache:masterapache/cloudstack:masterfrom
shapeblue:full-ovf-props-clean-frshapeblue/cloudstack:full-ovf-props-clean-frCopy head branch name to clipboard
Closed

[VMware] Full OVF properties support#4235
nvazquez wants to merge 116 commits intoapache:masterapache/cloudstack:masterfrom
shapeblue:full-ovf-props-clean-frshapeblue/cloudstack:full-ovf-props-clean-frCopy head branch name to clipboard

Conversation

@nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jul 31, 2020

Description

WIP description...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland and others added 30 commits July 30, 2020 21:33
@DaanHoogland @nvazquez
pokemon anihilation and class-javadoc
fa3e30e
@nvazquez
add ovf properties to template details
41ebfd0
@nvazquez
disected ova processing
432797e
@nvazquez
import
39722ee
@nvazquez
ovf string props hack
08d57ac
@nvazquez
refactor plan in comments
34d10ff
@nvazquez
trace
81f16a0
@nvazquez
hack to deal with: ovf property attributes in details
bda8848
@nvazquez
PoC code for properties iso
4bd8b37
@nvazquez
flag for deploy as is
3c219fc
@nvazquez
factor out 700 line start command and callees
0093a3b
@nvazquez
execute start; init of disk info factorred out
0768d3d
@DaanHoogland @nvazquez
license
43d5f2b
@nvazquez
howto pass deploy OVA as is?
3affec5
@nvazquez
logging during ingestion and guest net creation
0e47904
@nvazquez
more todos in comment
80a77d3
@nvazquez
tested in production '{' is really needed
7ab0e7e
@nvazquez
deploy ovf without stripping networks
925acc9
@nvazquez
deploy as is parameter to DB
83fff23
@nvazquez
show deploy as is hack
9306f33
@nvazquez
extract extension
f0c0ce7
@nvazquez
path correction
e70f78e
@nvazquez
further disect of start
892c780
@nvazquez
ui strings
0fde9d9
@nvazquez
parse networks for later reconsiliation
e0594cf
@nvazquez
debug and trace on registration time template processing
5592b00
@nvazquez
logging and NPE fixes
c544cdd
@nvazquez
template size over all disks
021032a
@nvazquez
template details to contain json descriptions
9e134d7
@nvazquez
make deployasis default in API
16f269e
@shwstppr
npe fix for network map
d97817b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Aug 5, 2020
@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

@nvazquez @shwstppr unit tests are failing, please review travis or local build and fix. I see:

...
[ERROR] testCheckAffinityNullPreferredHosts(com.cloud.vm.DeploymentPlanningManagerImplTest)  Time elapsed: 0.005 s  <<< ERROR!
org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'deploymentPlanningManagerImpl': Unsatisfied dependency expressed through field 'templateDao'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.cloud.storage.dao.VMTemplateDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
	at com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.cloud.storage.dao.VMTemplateDao' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@javax.inject.Inject()}
	at com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
[ERROR] Errors: 
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » UnsatisfiedDependency Error ...
[ERROR] Tests run: 846, Failures: 0, Errors: 7, Skipped: 5
...

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

Packaging result: ✖centos7 ✖debian. JID-1654

@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Aug 5, 2020

@blueorangutan package

@rhtyd why do you restart this, it has unit test failures? Did i miss a fix for those since they apeared?

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@shwstppr
Copy link
Contributor

shwstppr commented Aug 5, 2020

working on the unit test fix

@shwstppr
unit test fix
98092f1 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor

shwstppr commented Aug 5, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

Packaging result: ✔centos7 ✔debian. JID-1661

@yadvr
Copy link
Member

yadvr commented Aug 5, 2020

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

shwstppr and others added 2 commits August 5, 2020 16:31
@shwstppr
wip: vapps vm smoke test
ebdc456 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@nvazquez
Register templates as non-deploy-as-is if empty field
31af4fd
@nvazquez
Copy link
Contributor Author

nvazquez commented Aug 5, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

Packaging result: ✔centos7 ✔debian. JID-1664

@nvazquez
Copy link
Contributor Author

nvazquez commented Aug 5, 2020

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link

blueorangutan commented Aug 5, 2020

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Aug 6, 2020

Trillian test result (tid-2276)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49309 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2276-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 12 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_3d_gpu_support Error 327.04 test_deploy_vgpu_enabled_vm.py
test_00_deploy_vm_root_resize Failure 278.67 test_deploy_vm_root_resize.py
test_01_add_delete_kubernetes_supported_version Error 1807.57 test_kubernetes_supported_versions.py
test_reboot_router Error 239.07 test_network.py
test_03_nic_multiple_vmware Error 360.91 test_nic.py
test_10_project_activation Error 27.79 test_projects.py
test_01_reset_vm_on_reboot Error 17.48 test_reset_vm_on_reboot.py
test_08_start_router Error 13.38 test_routers.py
test_09_reboot_router Error 1.10 test_routers.py
test_04_change_offering_small Error 20.67 test_service_offerings.py
test_05_stop_ssvm Failure 920.82 test_ssvm.py
test_06_stop_cpvm Failure 919.71 test_ssvm.py
test_07_reboot_ssvm Failure 36.81 test_ssvm.py
test_01_volume_usage Error 90.60 test_usage.py
test_07_start_vm Error 17.45 test_vm_life_cycle.py
test_08_reboot_vm Error 1.10 test_vm_life_cycle.py
test_11_migrate_vm Error 52.91 test_vm_life_cycle.py

@yadvr
Copy link
Member

yadvr commented Aug 6, 2020

@nvazquez there are also Travis/simulator tests failing, pl check. I'll kick test against KVM for regression checks.

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Aug 6, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez
Copy link
Contributor Author

nvazquez commented Aug 6, 2020

Closing this PR - moving work to PR #4250

@nvazquez nvazquez closed this Aug 6, 2020
@blueorangutan
Copy link

blueorangutan commented Aug 6, 2020

Trillian test result (tid-2283)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43727 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2283-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_network_garbage_collector_nics Error 3855.17 test_vpc_redundant.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@yadvr yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

component:templates component:vmware Severity:Critical Critical bug

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @yadvr @blueorangutan @DaanHoogland @shwstppr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.