Debian10 support by yadvr · Pull Request #4104 · apache/cloudstack

yadvr · May 27, 2020

This upgrades the systemvmtemplate base to Debian 10 with openjdk-11.
Fixes #3654

Public location: (testing purposes, until GA)
http://download.cloudstack.org/systemvm/4.15/

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

This upgrades the systemvmtemplate base to Debian 10 with openjdk-11. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · May 27, 2020

@blueorangutan package

blueorangutan · May 27, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · May 27, 2020

Packaging result: ✔centos7 ✔debian. JID-1246

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · May 27, 2020

@blueorangutan package

blueorangutan · May 27, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · May 27, 2020

Packaging result: ✔centos7 ✔debian. JID-1248

blueorangutan · May 27, 2020

Trillian test result (tid-1571)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1571-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	356.68	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	342.19	test_vpc_redundant.py

DaanHoogland · May 28, 2020

@rhtyd can you incorporate teh change in #3921 in this one?

yadvr · May 28, 2020

@Spaceman1984 can you merge/push your PR commits (or patch https://patch-diff.githubusercontent.com/raw/apache/cloudstack/pull/3921.patch) to this branch?

yadvr · Jun 4, 2020

Looks like testing with kvm passed, we'll need to kick tests against other hypervisors manually from Trillian.
@blueorangutan package

blueorangutan · Jun 4, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Jun 4, 2020

Packaging result: ✖centos7 ✖debian. JID-1277

yadvr · Jun 4, 2020

@blueorangutan package

blueorangutan · Jun 4, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Jun 4, 2020

Packaging result: ✔centos7 ✔debian. JID-1287

yadvr · Jun 4, 2020

Kicked matrix smoketests on jenkins by overriding the built systemvmtemplates

DaanHoogland

code looks ok, of course every body needs to test 🤒

yadvr · Jun 4, 2020

The systemvmtemplate build log: http://download.cloudstack.org/systemvm/4.15/build.log
Public URL for dev-testing until GA: http://download.cloudstack.org/systemvm/4.15/

weizhouapache · Jun 4, 2020

@rhtyd I have two concerns
(1) does Trillian use new debian10 template in tests ?
(2) is python2 or python3 installed in debian10 ?

yadvr · Jun 4, 2020

Hi @weizhouapache

Trillian by default uses branch/version specific systevmtemplates, but allows option to override. For testing this PR, I'm not using BO but passing systemvmtemplate overide on our internal Jenkins. This gives us ability to test a PR with a new systemvmtemplate.
Currently, no python3 is not installed in this PR. Are you/anyone-else working to migrate VR scripts from py2 to py3, then I can make changes in this PR to install python3 (make the template future ready).

blueorangutan · Jun 4, 2020

Trillian test result (tid-1619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38950 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1619-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	1807.60	test_kubernetes_supported_versions.py

blueorangutan · Jun 4, 2020

Trillian test result (tid-1620)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1620-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · Jun 5, 2020

Hi @weizhouapache

Trillian by default uses branch/version specific systevmtemplates, but allows option to override. For testing this PR, I'm not using BO but passing systemvmtemplate overide on our internal Jenkins. This gives us ability to test a PR with a new systemvmtemplate.

Currently, no python3 is not installed in this PR. Are you/anyone-else working to migrate VR scripts from py2 to py3, then I can make changes in this PR to install python3 (make the template future ready).

@rhtyd nice, thanks.
let's merge it, and upgrade to python3 in systemvm template along with python2->python3 support (it seems to be part of centos8 support).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit f9cb0bfe51e12f704b4106c2d5484e2dce61fd7c) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · Jun 8, 2020

@weizhouapache Thanks, we'll merge this once the xenserver tests are also in.

I checked python3 was already installed on the built systemvmtemplate, but I've added explicit pkg to be installed
python2->3 migration is not done in the centos8 support PR; the systemvm continue to be on Debian where python2 ships by default (with the python package)

weizhouapache · Jun 8, 2020

code lgtm
did not test it

blueorangutan · Jun 8, 2020

Trillian test result (tid-1638)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1638-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	1863.68	test_kubernetes_clusters.py
test_01_scale_vm	`Failure`	24.62	test_scale_vm.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	459.52	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	403.47	test_vpc_redundant.py

yadvr · Jun 9, 2020

Checked test failures not related to this PR on XenServer, overall all tests have passed.
The cale_vm test case failure is due to license issue (it would pass on xcp-ng).

yadvr added 2 commits January 7, 2020 18:33

appliance: upgrade to Debian 10 systemvmtemplate

f003fa9

This upgrades the systemvmtemplate base to Debian 10 with openjdk-11. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

fix apache issue

a9c8b95

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added this to the 4.15.0.0 milestone May 27, 2020

yadvr added 4 commits May 27, 2020 09:28

Update configure_systemvm_services.sh

168a2b7

Update configure_systemvm_services.sh

346c7ad

Update template.json

0d7eefb

Merge remote-tracking branch 'origin/master' into debian10-support

82be1cf

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added 2 commits May 27, 2020 12:00

Merge remote-tracking branch 'origin/master' into debian10-support

b6555cc

update

bb4b1f5

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr requested review from andrijapanicsb and borisstoyanov May 27, 2020 06:35

yadvr assigned DaanHoogland and PaulAngus and unassigned DaanHoogland and PaulAngus May 27, 2020

yadvr requested review from DaanHoogland, GabrielBrascher, PaulAngus, weizhouapache and wido May 27, 2020 06:36

yadvr self-assigned this May 27, 2020

DaanHoogland changed the title ~~[WIP] Debian10 support~~ Debian10 support May 28, 2020

Updated virtual hardware version

c8dfadf

yadvr mentioned this pull request Jun 4, 2020

engine/schema: add empty DB upgrade path from 4.14.0.0 to 4.15.0.0 #4092

Merged

5 tasks

yadvr marked this pull request as ready for review June 4, 2020 03:16

DaanHoogland approved these changes Jun 4, 2020

View reviewed changes

yadvr added 2 commits June 8, 2020 07:18

let's install python3 futureproof; btw already installed on debian10

0c3951c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> (cherry picked from commit f9cb0bfe51e12f704b4106c2d5484e2dce61fd7c) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Merge remote-tracking branch 'origin/master' into debian10-support

d29de49

weizhouapache approved these changes Jun 8, 2020

View reviewed changes

yadvr merged commit 1e19ea5 into apache:master Jun 9, 2020

DaanHoogland added type:bug type:new-feature labels Oct 21, 2020

DaanHoogland added the Severity:Major label Nov 10, 2020

weizhouapache mentioned this pull request Aug 17, 2021

Files in /var/cache/cloud/processed on virtual router are not cleaned up #3757

Closed

Search code, repositories, users, issues, pull requests...

Conversation

yadvr commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr commented May 27, 2020

Uh oh!

blueorangutan commented May 27, 2020

Uh oh!

blueorangutan commented May 27, 2020

Uh oh!

yadvr commented May 27, 2020

Uh oh!

blueorangutan commented May 27, 2020

Uh oh!

blueorangutan commented May 27, 2020

Uh oh!

blueorangutan commented May 27, 2020

Uh oh!

DaanHoogland commented May 28, 2020

Uh oh!

yadvr commented May 28, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

weizhouapache commented Jun 4, 2020

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

weizhouapache commented Jun 5, 2020

Uh oh!

yadvr commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache commented Jun 8, 2020

Uh oh!

blueorangutan commented Jun 8, 2020

Uh oh!

yadvr commented Jun 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yadvr commented May 27, 2020 •

edited

Loading

yadvr commented Jun 8, 2020 •

edited

Loading

yadvr commented Jun 9, 2020 •

edited

Loading