Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CLOUDSTACK-7929: Unhandled exception when setting negative value for throttling rate while creating network offering #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anshul1886 wants to merge 1 commit into from
Closed

CLOUDSTACK-7929: Unhandled exception when setting negative value for throttling rate while creating network offering #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions 4 server/src/com/cloud/configuration/ConfigurationManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3723,6 +3723,10 @@ public NetworkOffering createNetworkOffering(CreateNetworkOfferingCmd cmd) {
throw new InvalidParameterValueException("Invalid value for Availability. Supported types: " + Availability.Required + ", " + Availability.Optional);
}

if (networkRate != null && networkRate < 0) {
Copy link
Member

@karuturi karuturi Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is networkRate == null a valid value?

Copy link
Author

@anshul1886 anshul1886 Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. it means that networkRate parameter is not passed and networkRate for this offering will be taken from other global settings

networkRate = 0;
}

Long serviceOfferingId = cmd.getServiceOfferingId();

if (serviceOfferingId != null) {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.