Rbd snapshot rollback#3502
Conversation
The snapshotRelPath contains a string such as: "poolName/volumeUuid/snapshotUuid"; thus, this commit splits the string and retrieves the necessary data for open and rollback snapshot.
|
This PR addresses issue #3498. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-151 |
|
@rhtyd rados-java 0.5.0 should be pushed to Maven Central tonight; therefore we need to wait a few hours so we can reckick Travis and blueorangutan. I will ping when rados-java gets updated, thanks! |
|
Okay @GabrielBrascher ping me when you want regression testing kicked. |
...shot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
Outdated
Show resolved
Hide resolved
|
@rhtyd rados java 0.5.0 is in maven central now |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-153 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-154 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-186)
|
...rage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/CephSnapshotStrategy.java
Outdated
Show resolved
Hide resolved
...ain/resources/META-INF/cloudstack/storage/spring-engine-storage-snapshot-storage-context.xml
Show resolved
Hide resolved
|
Left a minor remark, tests also LGTM. |
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM based on test results
Description
Add CephSnapshotStrategy to handle RBD revert (rollback) snapshot. In order to support RBD revert (rbd_rollback), this PR adds a CephSnapshotStrategy class to handle Ceph/RBD snapshot actions.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
(i) set
snapshot.backup.to.secondaryto false and restart ACS, ensuring that snapshots are stored directly on primary storage (Ceph/RBD)(ii) create multiple snapshots with changes (e.g. new files) and stop the VM
(iii) revert to a given snapshot
(iv) assert that rbd_snap_rollback is successfuly executed (remote debug evaulating the code)
(v) start the VM and check that the VM disk content is as expected