register template kvm context ui fix#2757
Merged
DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from Jul 20, 2018
ernjvr:register_template_kvm_context_fixernjvr/cloudstack:register_template_kvm_context_fixCopy head branch name to clipboard
Merged
register template kvm context ui fix#2757DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from ernjvr:register_template_kvm_context_fixernjvr/cloudstack:register_template_kvm_context_fixCopy head branch name to clipboard
DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from
ernjvr:register_template_kvm_context_fixernjvr/cloudstack:register_template_kvm_context_fixCopy head branch name to clipboard
Conversation
Contributor
Author
|
@rhtyd @nvazquez @priyankparihar @borisstoyanov Please review |
rafaelweingartner
approved these changes
Jul 19, 2018
DaanHoogland
approved these changes
Jul 20, 2018
borisstoyanov
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Jul 23, 2018
On the 'Register Template From URL' screen, when a user selects the KVM option from the Hypervisor dropdown: 1) It incorrectly displays the 'Original XS Version is 6.1' checkbox. This checkbox should be hidden in the KVM context. 2) The 'Root Disk Controller' dropdown should display the default option of 'osdefault' instead of a blank default option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the 'Register Template From URL' screen, when a user selects the KVM option from the Hypervisor dropdown:
Go to the 'Register Template From URL' screen by clicking the 'Templates' tab on the lefthand side.
On the 'Templates' screen click the 'Add' button to display the the 'Register Template From URL' screen.
On the 'Register Template From URL' screen, select the KVM option from the Hypervisor dropdown:
Types of changes
GitHub Issue/PRs
Screenshots (if appropriate):
How Has This Been Tested?
Manually. See the screenshot above.
Go to the 'Register Template From URL' screen by clicking the 'Templates' tab on the lefthand side.
On the 'Templates' screen click the 'Add' button to display the 'Register Template From URL' screen.
On the 'Register Template From URL' screen, select the KVM option from the Hypervisor dropdown:
CloudStack version 4.11, KVM hypervisor.
Checklist:
Testing