Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Changing to the right api call for securing hosts#2754

Closed
borisstoyanov wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:fix-securehost-migration-testshapeblue/cloudstack:fix-securehost-migration-testCopy head branch name to clipboard
Closed

Changing to the right api call for securing hosts#2754
borisstoyanov wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
shapeblue:fix-securehost-migration-testshapeblue/cloudstack:fix-securehost-migration-testCopy head branch name to clipboard

Conversation

@borisstoyanov
Copy link
Contributor

@borisstoyanov borisstoyanov commented Jul 19, 2018 •
edited
Loading

Description

This fixes the tests for secure live migration, looks like they were pointing to the wrong api call. However during testing of this I've hit a new issue #2753 which is blocking the tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

GitHub Issue/PRs

The tests will pass when #2753 is fixed, since they are using a parameter in the provisionCertificate api call which makes a NPE

Screenshots (if appropriate):

NA

How Has This Been Tested?

Locally with a debugger, api call seem right but it hits the mentioned issue

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@DaanHoogland DaanHoogland requested a review from yadvr July 20, 2018 07:08
DaanHoogland
DaanHoogland approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 20, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2195

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 20, 2018

@blueorangutan test

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 20, 2018

ERROR: Error cloning remote repo 'origin' !!!???
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 20, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2196

dhlaluku
dhlaluku approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@dhlaluku dhlaluku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueorangutan
Copy link

blueorangutan commented Jul 20, 2018

Trillian test result (tid-2874)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36416 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2874-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host Error 0.93 test_primary_storage.py
test_01_primary_storage_nfs Error 0.11 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.20 test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 1222.46 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 438.10 test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store Error 0.19 test_snapshots.py
test_01_secure_vm_migration Error 139.05 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 137.05 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 137.02 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 139.05 test_vm_life_cycle.py
test_08_migrate_vm Error 19.96 test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs Failure 0.13 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 2.35 test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance Error 5.61 test_hostha_kvm.py

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 23, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@borisstoyanov borisstoyanov force-pushed the fix-securehost-migration-test branch from eef6040 to a687337 Compare July 23, 2018 08:13
@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2199

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 23, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2201

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 23, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jul 23, 2018

Trillian test result (tid-2879)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27119 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2879-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host Error 0.65 test_primary_storage.py
test_01_primary_storage_nfs Error 0.12 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.22 test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 1107.33 test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store Error 1.16 test_snapshots.py
test_01_secure_vm_migration Error 132.94 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 131.91 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 132.94 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 131.91 test_vm_life_cycle.py
test_08_migrate_vm Error 15.84 test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs Failure 1.13 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1.29 test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance Error 4.58 test_hostha_kvm.py
test_hostha_kvm_host_fencing Failure 639.25 test_hostha_kvm.py
test_hostha_kvm_host_recovering Failure 618.70 test_hostha_kvm.py

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 24, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jul 24, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 24, 2018

vm_lifecycle tests are caused by the following issue #2763

@borisstoyanov borisstoyanov mentioned this pull request Jul 24, 2018
Merged
12 tasks
@blueorangutan
Copy link

blueorangutan commented Jul 24, 2018

Trillian test result (tid-2881)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32196 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2754-t2881-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 7 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_01_add_primary_storage_disabled_host Error 0.76 test_primary_storage.py
test_01_primary_storage_nfs Error 0.09 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.17 test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 1282.12 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 369.15 test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store Error 1.15 test_snapshots.py
test_01_secure_vm_migration Error 137.89 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 136.84 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 136.89 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 136.83 test_vm_life_cycle.py
test_08_migrate_vm Error 19.78 test_vm_life_cycle.py
test_01_cancel_host_maintenace_with_no_migration_jobs Failure 0.10 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1.26 test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance Error 1.43 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 8.52 test_hostha_kvm.py

@borisstoyanov
Copy link
Contributor Author

borisstoyanov commented Jul 25, 2018

Closing this in favor of #2764

@dhlaluku dhlaluku mentioned this pull request Aug 16, 2018
Merged
12 tasks
@snyk-bot snyk-bot mentioned this pull request Jul 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

+1 more reviewer

@dhlaluku dhlaluku dhlaluku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@borisstoyanov @blueorangutan @DaanHoogland @yadvr @dhlaluku
Morty Proxy This is a proxified and sanitized view of the page, visit original site.