Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

smoketest: Fix test_vm_life_cycle secure migration tests#2715

Merged
yadvr merged 2 commits intoapache:4.11apache/cloudstack:4.11from
shapeblue:smk-ca-testfixshapeblue/cloudstack:smk-ca-testfixCopy head branch name to clipboard
Jun 20, 2018
Merged

smoketest: Fix test_vm_life_cycle secure migration tests#2715
yadvr merged 2 commits intoapache:4.11apache/cloudstack:4.11from
shapeblue:smk-ca-testfixshapeblue/cloudstack:smk-ca-testfixCopy head branch name to clipboard

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Jun 19, 2018 •
edited
Loading

This fixes intermittently failing secure live VM migration tests on KVM.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

After fixing smoketest, ran the tests several times against two KVM CentOS7 monkeyboxes against which they passed.

Test secure VM migration ... === TestName: test_01_secure_vm_migration | Status : SUCCESS ===
ok
Test Non-secured VM Migration ... === TestName: test_02_unsecure_vm_migration | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_03_secured_to_nonsecured_vm_migration | Status : SUCCESS ===
ok
Test Non-secured VM Migration ... === TestName: test_04_nonsecured_to_secured_vm_migration | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 579.830s

OK

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@yadvr yadvr added this to the 4.11.1.0 milestone Jun 19, 2018
yadvr added 2 commits June 20, 2018 12:08
@yadvr
smoketest: Fix test_vm_life_cycle secure migration tests
6f6f306 
This fixes intermittently failing secure live VM migration tests on KVM.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
increase retry/count
7268133 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Member Author

yadvr commented Jun 20, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 20, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Jun 20, 2018
@apache apache deleted a comment from blueorangutan Jun 20, 2018
@apache apache deleted a comment from blueorangutan Jun 20, 2018
@apache apache deleted a comment from blueorangutan Jun 20, 2018
@blueorangutan
Copy link

blueorangutan commented Jun 20, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2139

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 20, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 20, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov
borisstoyanov approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix LGTM, lets wait for the results

@blueorangutan
Copy link

blueorangutan commented Jun 20, 2018

Trillian test result (tid-2777)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 18952 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2715-t2777-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup Error 102.00 test_privategw_acl.py

@yadvr yadvr merged commit d4e302d into apache:4.11 Jun 20, 2018
@yadvr
Copy link
Member Author

yadvr commented Jun 20, 2018

Merged based on test results and 2 lgtms.

ernjvr pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 3, 2018
@yadvr @ernjvr
smoketest: Fix test_vm_life_cycle secure migration tests (apache#2715)
bdfcf78 
This fixes intermittently failing secure live VM migration tests on KVM.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
bernardodemarco pushed a commit to scclouds/cloudstack that referenced this pull request Jul 16, 2025
Merge branch 'fix-migrate-with-snap-on-primary' into '4.20.0.0-scclouds'
889ce6b 
Adição de validação na API `migrateVirtualMachine`

Closes apache#2715

See merge request scclouds/scclouds!1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@rafaelweingartner rafaelweingartner Awaiting requested review from rafaelweingartner

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:kvm status:testing type:security

Projects

None yet

Milestone

4.11.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @blueorangutan @borisstoyanov @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.