ui: fix create VPC dialog box failure when zone is SG enabled#2704
Merged
DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from Jun 8, 2018
Merged
ui: fix create VPC dialog box failure when zone is SG enabled#2704DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from
DaanHoogland merged 1 commit intoapache:4.11apache/cloudstack:4.11from
Conversation
This fixes a case where at least the create VPC dialog/form is shown. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
Integration tests is not needed as this is purely UI fix. Review is requested. /cc @PaulAngus @DaanHoogland |
DaanHoogland
approved these changes
Jun 8, 2018
DaanHoogland
pushed a commit
that referenced
this pull request
Jun 12, 2018
* 4.11: comment on unencryption ui: fix create VPC dialog box failure when zone is SG enabled (#2704) CLOUDSTACK-10381: Fix password reset / reset ssh key with ConfigDrive isisnot= extra message debug message imports update without decrypt doesn't work set unsensitive attributes as not 'Secure' remove old config artifacts from update path
bernardodemarco
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Jul 16, 2025
…uds' Adição de propriedade a redes e VPCs para forçar a troca do MAC _address_ de NICs públicas de VRs Closes apache#1646 and apache#2704 See merge request scclouds/scclouds!1174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a case where at least the create VPC dialog/form is shown.
Types of changes
GitHub Issue/PRs
Fixes #2698
Screenshots (if appropriate):
Before the fix, the create VPC form does not show up. After the fix, the following is seen:
Note: SG + Adv zone does not allow VPC (at least from what I saw/found today).
How Has This Been Tested?
Deployed a KVM+SG zone and tried the fix with clicking on create VPC button. This shows up the form.
Checklist:
Testing