Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Catch error in Debian packaging script and fail the build#2649

Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
khos2ow:catch-packaging-error-debiankhos2ow/cloudstack:catch-packaging-error-debianCopy head branch name to clipboard
Jul 13, 2018
Merged

Catch error in Debian packaging script and fail the build#2649
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
khos2ow:catch-packaging-error-debiankhos2ow/cloudstack:catch-packaging-error-debianCopy head branch name to clipboard

Conversation

@khos2ow
Copy link
Contributor

@khos2ow khos2ow commented May 16, 2018

Description

This PR is going to:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@rafaelweingartner rafaelweingartner added this to the 4.12.0.0 milestone May 16, 2018
@khos2ow
Copy link
Contributor Author

khos2ow commented May 16, 2018

@rafaelweingartner @rhtyd this is essentially a follow up of #2627, for Debian builds.

@borisstoyanov
Copy link
Contributor

borisstoyanov commented May 17, 2018

thanks @khos2ow, let me run a build for this, @blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 17, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 17, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2059

@borisstoyanov
Copy link
Contributor

borisstoyanov commented May 18, 2018

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented May 18, 2018

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 18, 2018

Trillian test result (tid-2686)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22454 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2649-t2686-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 7 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_primary_storage_disabled_host Error 0.71 test_primary_storage.py
test_01_primary_storage_nfs Error 0.14 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.25 test_primary_storage.py
test_03_vpc_privategw_restart_vpc_cleanup Error 112.52 test_privategw_acl.py
test_02_list_snapshots_with_removed_data_store Error 1.16 test_snapshots.py
test_01_secured_vm_migration Error 36.49 test_vm_life_cycle.py
test_02_not_secured_vm_migration Error 36.54 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 36.52 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 36.47 test_vm_life_cycle.py
test_08_migrate_vm Error 14.87 test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn Failure 204.40 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Failure 133.75 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 139.88 test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs Failure 0.12 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 3.42 test_host_maintenance.py
test_hostha_kvm_host_fencing Failure 644.88 test_hostha_kvm.py
test_hostha_kvm_host_recovering Failure 619.19 test_hostha_kvm.py

@khos2ow khos2ow force-pushed the catch-packaging-error-debian branch from d20fa27 to dfe9b27 Compare May 18, 2018 19:00
@yadvr
Copy link
Member

yadvr commented May 21, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 21, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 21, 2018

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2070

@yadvr
Copy link
Member

yadvr commented May 21, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 21, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 21, 2018

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2071

@khos2ow
Copy link
Contributor Author

khos2ow commented May 22, 2018

@rhtyd the fact that debian build is failing on BO might actually be a good result, that the proposed enhancement in this PR works! Can you check/share the log of it?

@khos2ow
Catch error in packaging script and fail the build
0176bea 
This is to fix the regression added in apache#2433. In this fix
we're going to fail the build early if --use-timestamp is
provided and working directory is *not* clean. And also
fail the build if something in the script has returned
non-zero value.
@khos2ow khos2ow force-pushed the catch-packaging-error-debian branch from dfe9b27 to 0176bea Compare May 30, 2018 19:46
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 21, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2018

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2146

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 21, 2018

@blueorangutan help

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2018

@borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'ernjvr', 'dhlaluku', 'houthuis', 'charles-phiri']

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 21, 2018

@blueorangutan test ubuntu kvm-ubuntu

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2018

@borisstoyanov a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2018

Trillian test result (tid-2788)
Environment: kvm-ubuntu (x2), Advanced Networking with Mgmt server u
Total time taken: 23489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2649-t2788-kvm-ubuntu.zip
Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 61 look OK, 6 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_provision_certificate Error 5.17 test_certauthority_root.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup Error 100.26 test_privategw_acl.py
test_02_not_secured_vm_migration Error 80.41 test_vm_life_cycle.py
test_11_migrate_volume_and_change_offering Error 132.95 test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance Error 1.51 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 668.03 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 649.86 test_hostha_kvm.py

borisstoyanov
borisstoyanov approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on results and code review

@yadvr yadvr merged commit 4a5fab0 into apache:master Jul 13, 2018
@khos2ow khos2ow deleted the catch-packaging-error-debian branch July 13, 2018 13:49
borisstoyanov pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 23, 2018
@khos2ow @borisstoyanov
packaging: Catch error in packaging script and fail the build (apache…
337ed4c 
…#2649)

This is to fix the regression added in apache#2433. In this fix
we're going to fail the build early if --use-timestamp is
provided and working directory is *not* clean. And also
fail the build if something in the script has returned
non-zero value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@rafaelweingartner rafaelweingartner rafaelweingartner approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

@khos2ow khos2ow

Labels

type:enhancement

Projects

None yet

Milestone

4.12.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@khos2ow @borisstoyanov @blueorangutan @yadvr @rafaelweingartner
Morty Proxy This is a proxified and sanitized view of the page, visit original site.