CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".#2601
Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom May 1, 2018
Kui-Liu:setVxnetBrNameCopy head branch name to clipboard
Merged
CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".#2601yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom Kui-Liu:setVxnetBrNameCopy head branch name to clipboard
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
Kui-Liu:setVxnetBrNameCopy head branch name to clipboard
Conversation
rafaelweingartner
approved these changes
Apr 24, 2018
DaanHoogland
requested changes
Apr 27, 2018
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
get implies that it is retrieved from somewhere
| } | ||
|
|
||
| private String setVnetBrName(String pifName, String vnetId) { | ||
| private String getVnetBrName(String pifName, String vnetId) { |
Contributor
There was a problem hiding this comment.
i dont think getVnetBrName() is a good name, what it does is format/generate/create a vnetBrName! not get it from somewhere.
There was a problem hiding this comment.
Yes, that is to say, we may also name these methods as createXXX.
Right?
The three methods are named as "setXXX", Actually, they are not simple setter or getter. They are further renamed as "generateXXX" with dahn's comments.
yadvr
approved these changes
May 1, 2018
Member
|
@DaanHoogland you comment about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two methods are named as "setXXX",
actually, they are not setter but getter.
Thus, they should be renamed as "getXXX".