CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name#2366
CLOUDSTACK-10168 - VR duplicate entries in /etc/hosts when reusing VM name#2366yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom bwsw:CLOUDSTACK-10168-2Copy head branch name to clipboard
Conversation
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1430 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
| return dbag | ||
| remove_key = None | ||
| for key, entry in dbag.iteritems(): | ||
| if key <> 'id' and entry['host_name'] == data['host_name']: |
There was a problem hiding this comment.
<> is deprecated and removed in Python 3.x, please use != instead.
Bug is fixed. Fixed typo 'adress' to 'address' everywhere which leads to correct generation for agent communication json dhcp command.
|
@rhtyd code is fixed ( <> changed to != ) |
yadvr
left a comment
There was a problem hiding this comment.
Code approved, subject to test results.
yadvr
left a comment
There was a problem hiding this comment.
Tested locally, on redeploying an old VM with the same name, older entries are removing from /etc/hosts file.
|
@rhtyd |
|
Trillian test result (tid-1836)
|
|
Tests LGTM, merging based on two lgtms and results (ignoring known failures). |
Bug is fixed. Fixed typo 'adress' to 'address' everywhere which leads to correct generation for agent communication json dhcp command.
@rhtyd
@dagsonstebo
Take a look please. Fixes the bug reported by Dag Sonstebo for Basic zone but unable to test carefully for Advanced zone VR.
Tested in our pre-prod 4.10.
Create / abc (x.y.z.11), cde (x.y.z.13)
Remove / abc, cde
Create / cde -> /etc/hosts (x.y.z.11 -> cde, x.y.z.13 removed)