Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[CLOUDSTACK-10195] CloudStack MySQL HA problem -- No database selected#2364

Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
rafaelweingartner:fixMysqlHaWithNoDbNameExceptionrafaelweingartner/cloudstack:fixMysqlHaWithNoDbNameExceptionCopy head branch name to clipboard
Dec 19, 2017
Merged

[CLOUDSTACK-10195] CloudStack MySQL HA problem -- No database selected#2364
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
rafaelweingartner:fixMysqlHaWithNoDbNameExceptionrafaelweingartner/cloudstack:fixMysqlHaWithNoDbNameExceptionCopy head branch name to clipboard

Conversation

@rafaelweingartner
Copy link
Member

@rafaelweingartner rafaelweingartner commented Dec 18, 2017 •
edited
Loading

When using CloudStack with database HA configuration user receives warnings constantly saying “No database selected”.

This problem happens at com.cloud.cluster.ClusterManagerImpl.getHeartbeatTask().new ManagedContextRunnable(){...}.runInContext(), line 550. The scheme of the database is not properly set in the transaction when database HA options are enabled.

The problem was found and discussed in the following thread: http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201712.mbox/%3CCAOVNhEJUPYxE7Y04c1LKkGGJ1igXg3PAb8RL5vobjhAtX-%2BgTQ%40mail.gmail.com%3E

@rafaelweingartner
[CLOUDSTACK-10195] CloudStack MySQL HA problem -- No database selected
bb4afb9 
When using CloudStack with database HA configuration user receives warnings constantly saying “No database selected”.

This problem happens at com.cloud.cluster.ClusterManagerImpl.getHeartbeatTask().new ManagedContextRunnable(){...}.runInContext(), line 550. The scheme of the database is not properly set in the transaction when database HA options are enabled.
@yadvr
Copy link
Member

yadvr commented Dec 18, 2017

@rafaelweingartner why was the unit test removed?

@rafaelweingartner
Copy link
Member Author

rafaelweingartner commented Dec 18, 2017

Because it was testing the method txn.transitToUserManagedConnection(getHeartbeatConnection()).
I replaced the use of this method by txn.transitToAutoManagedConnection(TransactionLegacy.CLOUD_DB);

If you see in that code at line 600, after "trying" to reuse a connection if something goes wrong, it will try to transit to a transaction using schema "Cloud_DB", and then it will close the transaction. The only place where the transaction was "reused" is there. So, when I changed txn.transitToUserManagedConnection(getHeartbeatConnection()) to txn.transitToAutoManagedConnection(TransactionLegacy.CLOUD_DB);, the first method could be deleted. After that, I inspected and this method is not used anywhere else. Therefore, I also removed the method and its test cases.

@yadvr
Copy link
Member

yadvr commented Dec 18, 2017

Alright, let me kick some tests.
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 18, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 18, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1405

@yadvr
Copy link
Member

yadvr commented Dec 18, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Dec 18, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rafaelweingartner
Copy link
Member Author

rafaelweingartner commented Dec 18, 2017

@rhtyd Thanks!

@blueorangutan
Copy link

blueorangutan commented Dec 19, 2017

Trillian test result (tid-1819)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2364-t1819-kvm-centos7.zip
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_vpc_privategw_acl Failure 57.11 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 289.33 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 133.22 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 465.52 test_privategw_acl.py
test_02_create_template_with_checksum_sha1 Error 5.29 test_templates.py
test_03_create_template_with_checksum_sha256 Error 5.23 test_templates.py
test_04_create_template_with_checksum_md5 Error 5.25 test_templates.py
test_01_vpc_remote_access_vpn Error 55.92 test_vpc_vpn.py

@yadvr
Copy link
Member

yadvr commented Dec 19, 2017

Tests LGTM. We'll need an additional review on this.

@yadvr yadvr added this to the 4.11 milestone Dec 19, 2017
@rafaelweingartner
Copy link
Member Author

rafaelweingartner commented Dec 19, 2017

@khos2ow, @nvazquez, @DaanHoogland, @GabrielBrascher can some of you review this PR as well?

GabrielBrascher
GabrielBrascher approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @rafaelweingartner. Code LGTM.

nvazquez
nvazquez approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Member

yadvr commented Dec 19, 2017

Merging based on reviews and test results.

@yadvr yadvr merged commit 9179bd5 into apache:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rafaelweingartner @yadvr @blueorangutan @GabrielBrascher @nvazquez
Morty Proxy This is a proxified and sanitized view of the page, visit original site.