CLOUDSTACK-10043: fix restore default drop for egress rules in ACL#2323
Closed
resmo wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
resmo:fix/vpc_acl_egress_default_dropCopy head branch name to clipboard
Closed
CLOUDSTACK-10043: fix restore default drop for egress rules in ACL#2323resmo wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom resmo:fix/vpc_acl_egress_default_dropCopy head branch name to clipboard
resmo wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
resmo:fix/vpc_acl_egress_default_dropCopy head branch name to clipboard
Conversation
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1252 |
Member
|
@resmo are you planning to work on option 3 (from dev@ ML) or go with this change (drop by default) ? |
Member
Author
|
I would say, close this PR and I am going for the option 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While verifying the fix for CLOUDSTACK-10135 in #2313 we found a regression.
At least to version 4.5.x (verified in 4.5.3) every ACL hat a default drop for egress (ACL_OUTBOUND). This commit restores this behavior (regression fix)Ok, after some more investigation and help of @fmaximus it seems the 4.5 implementation is wrong as well. It does not add a deny egress all but a deny egress all if there is any egress rule (even a deny), but anyway.
This is a not a bug fix anymore but a default deny.
/cc @rhtyd @yvsubhash