Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat#2304

Merged
yadvr merged 1 commit intoapache:4.9apache/cloudstack:4.9from
nuagenetworks:bugfix/CLOUDSTACK-10127nuagenetworks/cloudstack:bugfix/CLOUDSTACK-10127Copy head branch name to clipboard
Dec 23, 2017
Merged

CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat#2304
yadvr merged 1 commit intoapache:4.9apache/cloudstack:4.9from
nuagenetworks:bugfix/CLOUDSTACK-10127nuagenetworks/cloudstack:bugfix/CLOUDSTACK-10127Copy head branch name to clipboard

Conversation

@fmaximus
Copy link
Contributor

@fmaximus fmaximus commented Nov 1, 2017

No description provided.

@yadvr
Copy link
Member

yadvr commented Nov 2, 2017

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 2, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 2, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1190

@yadvr
Copy link
Member

yadvr commented Nov 2, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 2, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 2, 2017

Trillian test result (tid-1607)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1607-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 47 look OK, 7 have error(s)

Test Result Time (s) Test File
test_02_VPC_default_routes Failure 823.28 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Failure 858.30 test_vpc_router_nics.py
test_05_rvpc_multi_tiers Failure 181.41 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Failure 843.35 test_vpc_redundant.py
test_04_rvpc_privategw_static_routes Failure 1020.25 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 909.93 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 934.84 test_privategw_acl.py
test_05_iso_permissions Failure 0.05 test_iso.py
test_02_edit_iso Failure 0.05 test_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Failure 226.83 test_internal_lb.py
test_01_vpc_site2site_vpn Error 357.55 test_vpc_vpn.py
test_01_single_VPC_iptables_policies Error 822.61 test_routers_iptables_default_policy.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 241.95 test_internal_lb.py
test_03_delete_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_02_revert_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_01_create_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.01 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.03 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.00 test_deploy_vgpu_enabled_vm.py

@yadvr
Copy link
Member

yadvr commented Nov 5, 2017

Several failures seen, I'll rerun tests.
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 5, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 5, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1208

@yadvr
Copy link
Member

yadvr commented Nov 5, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 5, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2017

Trillian test result (tid-1619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35255 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1619-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 48 look OK, 6 have error(s)

Test Result Time (s) Test File
test_02_VPC_default_routes Failure 893.04 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Failure 822.59 test_vpc_router_nics.py
test_04_rvpc_privategw_static_routes Failure 1004.25 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 984.15 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 908.70 test_privategw_acl.py
test_05_iso_permissions Failure 0.04 test_iso.py
test_02_edit_iso Failure 0.04 test_iso.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Failure 236.22 test_internal_lb.py
test_01_vpc_site2site_vpn Error 362.93 test_vpc_vpn.py
test_01_single_VPC_iptables_policies Error 867.35 test_routers_iptables_default_policy.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 251.53 test_internal_lb.py
test_03_delete_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_02_revert_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_01_create_vm_snapshots Skipped 0.00 test_vm_snapshots.py
test_09_copy_delete_template Skipped 0.01 test_templates.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.01 test_staticroles.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.03 test_primary_storage.py
test_vm_nic_adapter_vmxnet3 Skipped 0.00 test_nic_adapter_type.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.01 test_deploy_vgpu_enabled_vm.py

@yadvr
Copy link
Member

yadvr commented Nov 6, 2017

@fmaximus can you check new/additional failures than the baseline failures seen in #2289

@svenvogel
Copy link
Contributor

svenvogel commented Nov 8, 2017

@fmaximus is it ready for test or do we need to fix the checks first?

@fmaximus
Copy link
Contributor Author

fmaximus commented Nov 9, 2017

@rhtyd This branch is against 4.9, is there a baseline of failures on 4.9?

@yadvr
Copy link
Member

yadvr commented Nov 9, 2017

@fmaximus I think I closed that old PR, can kick one over the weekend.

@svenvogel
Copy link
Contributor

svenvogel commented Nov 9, 2017

@rhtyd Close the old PR? Which one is the old one?

@yadvr
Copy link
Member

yadvr commented Nov 9, 2017

@svenvogel Frank asked if we've a 4.9 baseline to compare against, I closed the last 4.9 smoketests PR #2217

@svenvogel
Copy link
Contributor

svenvogel commented Nov 12, 2017 •
edited
Loading

Hi @fmaximus, Hi @rhtyd

we checked it again, it was our mistake. work in 4.10 without any problem.

+1

@svenvogel
Copy link
Contributor

svenvogel commented Nov 18, 2017 •
edited
Loading

@fmaximus

Now we tried it with redundant VPC offering. It seems the same problem like this Bug. Normal offer is fixed with this but not redundant Offering. Thats not fixed with this pull request.

@fmaximus can this fix also applied to redundant offering?

thanks

Sven

@yadvr
Copy link
Member

yadvr commented Nov 23, 2017

@fmaximus I see several failures compared to baseline 4.9 tests results: #2318

@yadvr
Copy link
Member

yadvr commented Nov 23, 2017

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 23, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 23, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1286

@yadvr
Copy link
Member

yadvr commented Nov 23, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 23, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@fmaximus
Copy link
Contributor Author

fmaximus commented Dec 20, 2017

Rewrite using Mac Address, should work now.
Checked the implementation for PrivateGateway on LinuxBridge.

@yadvr
Copy link
Member

yadvr commented Dec 20, 2017

Thanks @fmaximus I'll kick another round of tests
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 20, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Dec 20, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1446

@yadvr
Copy link
Member

yadvr commented Dec 20, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Dec 20, 2017

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Dec 21, 2017

Trillian test result (tid-1852)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24225 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1852-kvm-centos7.zip
Smoke tests completed. 51 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_edit_iso Failure 0.08 test_iso.py
test_05_iso_permissions Failure 0.07 test_iso.py
test_04_rvpc_privategw_static_routes Failure 447.95 test_privategw_acl.py
test_10_attachAndDetach_iso Error 31.96 test_vm_life_cycle.py

@yadvr
Copy link
Member

yadvr commented Dec 21, 2017

Test LGTM, I'll check if rest of the failures are related to PR or environment introduced. Additional review requested - @marcaurele @wido @ustcweizhou @rafaelweingartner and others.

@yadvr yadvr changed the base branch from 4.9 to master December 22, 2017 09:39
@yadvr
Copy link
Member

yadvr commented Dec 22, 2017

For testing purposes, I've changed the branch's base to master to kick tests. Once they are okay, we can merge this.
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Dec 22, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr
yadvr approved these changes Dec 22, 2017
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, subject to testing.

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Dec 22, 2017

let me test this blocker as well

@yadvr
Copy link
Member

yadvr commented Dec 22, 2017

I'll close and re-open this PR to re-kick travis, it's not pick up changes and failing due to base branch changes not propagated.

@yadvr yadvr closed this Dec 22, 2017
@yadvr yadvr reopened this Dec 22, 2017
@blueorangutan
Copy link

blueorangutan commented Dec 22, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1459

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Dec 22, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Dec 22, 2017

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Dec 22, 2017

Trillian test result (tid-1868)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29486 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2304-t1868-kvm-centos7.zip
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_vpc_privategw_acl Failure 61.83 test_privategw_acl.py
test_02_vpc_privategw_static_routes Failure 178.18 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 147.95 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 243.58 test_privategw_acl.py
test_02_create_template_with_checksum_sha1 Error 5.22 test_templates.py
test_03_create_template_with_checksum_sha256 Error 5.23 test_templates.py
test_04_create_template_with_checksum_md5 Error 5.22 test_templates.py
test_01_vpc_remote_access_vpn Failure 76.10 test_vpc_vpn.py

borisstoyanov
borisstoyanov approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on test results and code review

@yadvr yadvr changed the base branch from master to 4.9 December 23, 2017 03:46
@yadvr yadvr merged commit c12e138 into apache:4.9 Dec 23, 2017
@yadvr
Copy link
Member

yadvr commented Dec 23, 2017

Merged based on two lgtms and test results.

@yadvr yadvr mentioned this pull request Dec 26, 2017
Closed
@svenvogel svenvogel mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:kvm component:virtual-router component:vpc Severity:BLOCKER type:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmaximus @yadvr @blueorangutan @svenvogel @borisstoyanov
Morty Proxy This is a proxified and sanitized view of the page, visit original site.