Fixed two coverity reported issues#219
Closed
karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
karuturi:upload-coverityCopy head branch name to clipboard
Closed
Fixed two coverity reported issues#219karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom karuturi:upload-coverityCopy head branch name to clipboard
karuturi wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
karuturi:upload-coverityCopy head branch name to clipboard
Conversation
Dereference after null check Dm: Dubious method used
|
cloudstack-pull-requests #80 SUCCESS |
Contributor
|
LGTM. If you are sure the bytes are always UTF8 and not platform defined, this is fine. |
Contributor
|
travis has errors in one of the jobs:( not related to the checkin ASAICT |
Member
Author
|
In the current usage of it, they are utf8. Also, it uses UTF-8 for the key. I will go ahead and merge. Thanks for the review Daan. |
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Fixes #180 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dereference after null check
Dm: Dubious method used