CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type by jayapalu · Pull Request #2128 · apache/cloudstack

jayapalu · May 25, 2017

Updated the traffic_type to PrivateGw to avoid configuring keepalied on the private gateway interface.
For more details about the bug please see CLOUDSTACK-9885

cloudmonger · May 29, 2017

ACS CI BVT Run

Sumarry:
Build Number 768
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

test_routers_network_ops.py
test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

yadvr · Nov 30, 2017

@blueorangutan package

blueorangutan · Nov 30, 2017

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Nov 30, 2017

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1329

yadvr · Dec 1, 2017

@jayapalu please fix the conflicts and build failures

yadvr · Dec 11, 2017

@jayapalu can you fix conflicts and move sql related changes to appropriate 4.10->4.11 path?

yadvr · Dec 19, 2017

@jayapalu this is marked as a blocker, can you help fix this? Thanks.

yadvr · Dec 22, 2017

Ping @jayapalu can you please respond? This issue is marked as blocker in jira. /cc @karuturi @sateesh-chodapuneedi @priyankparihar @yvsubhash and others at Accelerite who may want to work with the community on this?

yadvr · Jan 2, 2018

ping @jayapalu

I'll remove this from 4.11 milestone due to lack of engagement, response from the author and discussions.

Updated the traffic_type to PrivateGw to avoid configuring keepalied on the private gateway interface. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · Jan 7, 2018

server/src/com/cloud/network/guru/PrivateNetworkGuru.java

    EntityManager _entityMgr;

-    private static final TrafficType[] TrafficTypes = {TrafficType.Guest};
+    private static final TrafficType[] TrafficTypes = {TrafficType.PrivateGw};


Will this cause regression @jayapalu ? /cc @ustcweizhou

yadvr · Jan 7, 2018

@blueorangutan package

blueorangutan · Jan 7, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · Jan 7, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1612

yadvr · Jan 7, 2018

@blueorangutan test

blueorangutan · Jan 7, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · Jan 8, 2018

Trillian test result (tid-2068)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29768 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2128-t2068-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	`Failure`	41.03	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	101.85	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	111.95	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	157.04	test_privategw_acl.py
test_02_attach_volume	`Failure`	669.80	test_volumes.py
test_07_resize_fail	`Failure`	15.23	test_volumes.py

yadvr · Jan 8, 2018

@jayapalu can you address outstanding questions and look at failures?
@ustcweizhou since you've had fixed the issue in a different way, can you help review the PR? Thanks.

yadvr · Jan 9, 2018

Given there is no engagement from the author and this issue is a specific case, does not block the release I'll move this to 4.12 milestone. /cc @jayapalu

yadvr · Oct 8, 2018

Essentially, the private gateway from a user point of view is still a kind guest network type providing access for guest VMs. I started by extending/fixing this PR but found it to be not necessary to add a new traffic type to fix this which will also require codebase-wide refactoring and additional checks wherever TrafficType.Guest is used throughout the codebase.

In #2888 the VR nics are aggregated and programmed by the nic device order and in the VR the ip_association is handled such that the device order is found by referencing the mac address for an ipaddress than the device id from the json. /cc @PaulAngus

I'm still able to reproduce the issue https://issues.apache.org/jira/browse/CLOUDSTACK-9885 in case of rVRs but I think it's solvable by adding a new boolean to say whether a guest network nic is a private gateway and handle that case in VR.

andrijapanicsb · Jan 4, 2020

I'm closing this one @JayapalUradi @jayapalu due to 2.5 years of inactivity. Kindly reopen if you have time to work on this one.

jayapalu added the type:bug label May 25, 2017

yadvr added this to the 4.11 milestone Dec 19, 2017

yadvr added the Severity:BLOCKER label Dec 22, 2017

yadvr modified the milestone: 4.11 Jan 2, 2018

CLOUDSTACK-9885: VPCVR: Updated to the private the traffic_type

6161602

Updated the traffic_type to PrivateGw to avoid configuring keepalied on the private gateway interface. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr reviewed Jan 7, 2018

View reviewed changes

yadvr removed the Severity:BLOCKER label Jan 8, 2018

yadvr modified the milestones: 4.11, 4.12 Jan 9, 2018

yadvr mentioned this pull request Jun 21, 2018

Restarting of non-redundant VPC with private gateway fails sometimes #2719

Closed

rafaelweingartner removed this from the 4.12.0.0 milestone Jan 9, 2019

richardlawley mentioned this pull request Jun 12, 2019

VPC RVR: Delete first tier with Private GW - Both VRs become MASTER #3402

Closed

yadvr added this to the 4.14.0.0 milestone Jun 20, 2019

andrijapanicsb closed this Jan 4, 2020

Search code, repositories, users, issues, pull requests...

Conversation

jayapalu commented May 25, 2017

Uh oh!

cloudmonger commented May 29, 2017

ACS CI BVT Run

Uh oh!

yadvr commented Nov 30, 2017

Uh oh!

blueorangutan commented Nov 30, 2017

Uh oh!

blueorangutan commented Nov 30, 2017

Uh oh!

yadvr commented Dec 1, 2017

Uh oh!

yadvr commented Dec 11, 2017

Uh oh!

yadvr commented Dec 19, 2017

Uh oh!

yadvr commented Dec 22, 2017

Uh oh!

yadvr commented Jan 2, 2018

Uh oh!

yadvr Jan 7, 2018

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jan 7, 2018

Uh oh!

blueorangutan commented Jan 7, 2018

Uh oh!

blueorangutan commented Jan 7, 2018

Uh oh!

yadvr commented Jan 7, 2018

Uh oh!

blueorangutan commented Jan 7, 2018

Uh oh!

blueorangutan commented Jan 8, 2018

Uh oh!

yadvr commented Jan 8, 2018

Uh oh!

yadvr commented Jan 9, 2018

Uh oh!

yadvr commented Oct 8, 2018

Uh oh!

andrijapanicsb commented Jan 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants