CLOUDSTACK-8830 : VM snapshot creation fails for 12 min #2118
Merged
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom Jul 23, 2017
Merged
CLOUDSTACK-8830 : VM snapshot creation fails for 12 min #2118yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
yadvr merged 1 commit intoapache:masterapache/cloudstack:masterfrom
Conversation
Contributor
Author
|
Travis CI build failed due to smoke/test_outofbandmanagement which is not connected to this code. |
7727834 to
7402d14
Compare
| time_elapsed < 600, | ||
| "Snapshot did not get created in the first 10 minutes after VM creation" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Sometimes VM snapshot may take more than 10 mins. In that case this assertion would be false. So better create VM snapshot after instance creation and check it failed or not.
| snapshot_created_1, | ||
| "Snapshot creation failed" | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
If create VM snapshot fails immediately after instance creation, the issue might exists.
Contributor
|
Test code LGTM |
|
LGTM |
Member
|
Can you post test results? |
borisstoyanov
approved these changes
Jul 4, 2017
Contributor
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM based on code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#ISSUE
VM snapshot fails for 12 min after instance creation
#FIX
This PR adds a marvin test case for the fix at #1677
Test case add to check whether VMSnapshot is successful from the moment the VM is ready