Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot#2043

Merged
karuturi merged 1 commit intoapache:4.9apache/cloudstack:4.9from
anshul1886:CLOUDSTACK-9876anshul1886/cloudstack-1:CLOUDSTACK-9876Copy head branch name to clipboard
Apr 18, 2017
Merged

CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot#2043
karuturi merged 1 commit intoapache:4.9apache/cloudstack:4.9from
anshul1886:CLOUDSTACK-9876anshul1886/cloudstack-1:CLOUDSTACK-9876Copy head branch name to clipboard

Conversation

@anshul1886
Copy link

As we no longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together

@karuturi
Copy link
Member

@rhtyd @serg38 can you review?

@serg38
Copy link

serg38 commented Apr 14, 2017

LGTM on the code change.
@borisstoyanov @rhtyd @DaanHoogland Can we re-kick vmware test for this PR?

@yadvr
Copy link
Member

yadvr commented Apr 15, 2017

LGTM. @anshul1886 this needs to go into 4.9 as well since the enhacement PR was for 4.9 and merged on 4.9, fwd-merged on master. Pl change the PR's branch to 4.9.

@karuturi karuturi self-assigned this Apr 17, 2017
@yadvr
Copy link
Member

yadvr commented Apr 17, 2017

Ping @anshul1886

@anshul1886 anshul1886 changed the base branch from master to 4.9 April 17, 2017 07:03
@anshul1886 anshul1886 changed the base branch from 4.9 to master April 17, 2017 07:04
…o longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together
@anshul1886 anshul1886 changed the base branch from master to 4.9 April 17, 2017 07:16
@anshul1886
Copy link
Author

@rhtyd @karuturi @serg38 Changed the base to 4.9 branch.

@anshul1886 anshul1886 closed this Apr 17, 2017
@anshul1886 anshul1886 reopened this Apr 17, 2017
@karuturi karuturi merged commit 41b7eee into apache:4.9 Apr 18, 2017
@yadvr
Copy link
Member

yadvr commented Apr 18, 2017

Thanks @anshul1886 lgtm

@karuturi karuturi modified the milestone: 4.10.0.0 Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.