VPC and Virtual Network Managers refactor. Part of the VPC Redundant Router work#19

Closed

wilderrodrigues wants to merge 160 commits intoapache:masterfrom

schubergphilis:vpc-refactor-rvr-final

Commits on Sep 11, 2014

Rules and visitors for Load Balance Rules

Antonio Fornie
authored and
wilderrodrigues
committed
f7a85d2
Copy full SHA for f7a85d2
Adding new behaviour to the apply load balancing rules method. The whole chain has been implemented and we will now test it.
wilderrodrigues
committed
cdd30b7
Copy full SHA for cdd30b7
Extract general behavior to Router and Vpc delegates

Antonio Fornie
authored and
wilderrodrigues
committed
2229d99
Copy full SHA for 2229d99
Fix dependency problem. Extract and unify router deployment stuff

Antonio Fornie
authored and
wilderrodrigues
committed
a4a8232
Copy full SHA for a4a8232
Adding Firewall Rules to comply with the Visitor pattern implementation; refactoring the applyRules so we can reuse it.

Wilder Rodrigues
authored and
wilderrodrigues
committed
fdbf1a2
Copy full SHA for fdbf1a2
changing accessor modifier in instance variables

Wilder Rodrigues
authored and
wilderrodrigues
committed
f89f3b3
Copy full SHA for f89f3b3
fixing checkstyles
wilderrodrigues
committed
0e9e109
Copy full SHA for 0e9e109
finished firewall rules and load balancing rules; fixed all the injection problems; added VirtualMachineManager to the appliance factory to be injected.
wilderrodrigues
committed
3fbb2a1
Copy full SHA for 3fbb2a1
TODO

DaanHoogland
authored and
wilderrodrigues
committed
f44def9
Copy full SHA for f44def9
adding static nat rules. Deploying new VMs is not working due to the appliance refactory, will check the changes with Antonio tomorrow.
wilderrodrigues
committed
492249d
Copy full SHA for 492249d
we have to check if VPC is null bfore calling it. VPC is not used in gest networks, so deploying a new VM was broken.
wilderrodrigues
committed
8979acb
Copy full SHA for 8979acb
adding apache license headers
wilderrodrigues
committed
327cd3f
Copy full SHA for 327cd3f
adding Ip Association and VPN Rules
wilderrodrigues
committed
70af2e7
Copy full SHA for 70af2e7
Fix offering setup

Antonio Fornie
authored and
wilderrodrigues
committed
8a4a74d
Copy full SHA for 8a4a74d
package rename

DaanHoogland
authored and
wilderrodrigues
committed
948b9c6
Copy full SHA for 948b9c6
Temporary put state info in a state object

Antonio Fornie
authored and
wilderrodrigues
committed
224ef76
Copy full SHA for 224ef76
fixing the classes relationship; adding beans properly in the spring context; using the right basic/advance stuff; testing ip and port forwarding rules
wilderrodrigues
committed
865abac
Copy full SHA for 865abac
adding password to router rules; moving the advance code to the advance net topology.
wilderrodrigues
committed
e2071f9
Copy full SHA for e2071f9
Unify and encapsulate deployment flow methods and params

Antonio Fornie
authored and
wilderrodrigues
committed
1bfd40e
Copy full SHA for 1bfd40e
adding userdata to router and ssh pub key to router rules.
wilderrodrigues
committed
c571aa2
Copy full SHA for c571aa2
making instance variables compliant with ACS convention
wilderrodrigues
committed
c40ecf2
Copy full SHA for c40ecf2
adding user data pwd rules
wilderrodrigues
committed
ee8b027
Copy full SHA for ee8b027
adding DHCP entry rules
wilderrodrigues
committed
770c12b
Copy full SHA for 770c12b
fixing injection of beans with a relationship
wilderrodrigues
committed
2abf343
Copy full SHA for 2abf343
whitespace

DaanHoogland
authored and
wilderrodrigues
committed
565f77f
Copy full SHA for 565f77f
fixing the injection of the networkDao
wilderrodrigues
committed
1cdcb1c
Copy full SHA for 1cdcb1c
mv to better name
Show description for d84929e

DaanHoogland
authored and
wilderrodrigues
committed
d84929e
Copy full SHA for d84929e
Deployment more OO - Objects with data and behavior

Antonio Fornie
authored and
wilderrodrigues
committed
bdef2f8
Copy full SHA for bdef2f8
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues
committed
4f93ef2
Copy full SHA for 4f93ef2
fixing import in virtual router element and checkstyle in dhcp entry related changes
wilderrodrigues
committed
ee0389b
Copy full SHA for ee0389b
commenting broken code in tests in order to run build adn tests other changes via the UI
wilderrodrigues
committed
4252825
Copy full SHA for 4252825
removing bean from the xml
wilderrodrigues
committed
0ba539c
Copy full SHA for 0ba539c
adding new bean to spring context file; renaming package from "com" to "org"
wilderrodrigues
committed
4ee726e
Copy full SHA for 4ee726e
Missing dependencies are added

Antonio Fornie
authored and
wilderrodrigues
committed
1d0c83f
Copy full SHA for 1d0c83f
Fixing null pointers during vpc router deployment

Antonio Fornie
authored and
wilderrodrigues
committed
a0ded3d
Copy full SHA for a0ded3d
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues
committed
bf7fb4a
Copy full SHA for bf7fb4a
fixing VPC IP Association and ACL rules. Have to rewrite in a better why the apply rules method in the Advanced Topology
wilderrodrigues
committed
7effc0a
Copy full SHA for 7effc0a
Splitting Vpc and NonVpc deployment into phases & testing it

Antonio Fornie
authored and
wilderrodrigues
committed
938d3df
Copy full SHA for 938d3df
RouterDeployment and VPC. Improving code and Unit Testing

Antonio Fornie
authored and
wilderrodrigues
committed
8673535
Copy full SHA for 8673535
rename networkMgr to networkMdl to prevent name clashes in mocks of
Show description for cfef413

DaanHoogland
authored and
wilderrodrigues
committed
cfef413
Copy full SHA for cfef413
More refactoring and testing in the same classes

Antonio Fornie
authored and
wilderrodrigues
committed
6c41f16
Copy full SHA for 6c41f16
License headers

Antonio Fornie
authored and
wilderrodrigues
committed
7304a39
Copy full SHA for 7304a39
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
Show description for e29de5f
wilderrodrigues
committed
e29de5f
Copy full SHA for e29de5f
Complete tests for normal deployment and start vpc one

Antonio Fornie
authored and
wilderrodrigues
committed
d5a35ac
Copy full SHA for d5a35ac
Factor out prepareDeployment and update tests

Antonio Fornie
authored and
wilderrodrigues
committed
930ee56
Copy full SHA for 930ee56
Increasing test coverage for Vpc Deployment

Antonio Fornie
authored and
wilderrodrigues
committed
af3189c
Copy full SHA for af3189c
Fix unnecessary changes Spring contexts

Antonio Fornie
authored and
wilderrodrigues
committed
408cde6
Copy full SHA for 408cde6
Adding VpcRouterDeploymentDefinition Unit Tests

Antonio Fornie
authored and
wilderrodrigues
committed
5d57236
Copy full SHA for 5d57236
moving sendCommand to the NetworkGeneralHelper;
Show description for 812e9e5
wilderrodrigues
committed
812e9e5
Copy full SHA for 812e9e5
fixing check styles
wilderrodrigues
committed
669e074
Copy full SHA for 669e074
Refactor to include network creation as actual deployment

Antonio Fornie
authored and
wilderrodrigues
committed
40df9d4
Copy full SHA for 40df9d4
adding applyStaticRoutes method to the network topology/visitor. it will be used by the VPC virtual net manager appliance.
wilderrodrigues
committed
1eadf84
Copy full SHA for 1eadf84
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues
committed
bdde077
Copy full SHA for bdde077
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
Show description for 6353c74
wilderrodrigues
committed
6353c74
Copy full SHA for 6353c74
DeployRouter includes nw creation following TellDontAsk principle
Show description for 003fba6

Antonio Fornie
authored and
wilderrodrigues
committed
003fba6
Copy full SHA for 003fba6
Whole router.deployment package got 97% coverage

Antonio Fornie
authored and
wilderrodrigues
committed
c7f6998
Copy full SHA for c7f6998
adding setupPrivateGateway to new style;
Show description for 0b8b22f
wilderrodrigues
committed
0b8b22f
Copy full SHA for 0b8b22f
fixing the private gateway rules in order to comply with changes in the vpc helper
wilderrodrigues
committed
404f711
Copy full SHA for 404f711
fixing check style issues
wilderrodrigues
committed
5e11fba
Copy full SHA for 5e11fba
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers

Antonio Fornie
authored and
wilderrodrigues
committed
bac85e5
Copy full SHA for bac85e5
Missing license headers

Antonio Fornie
authored and
wilderrodrigues
committed
5195790
Copy full SHA for 5195790
refactor all private methods in the virtual router appliance and VPC appliance
wilderrodrigues
committed
06c77f1
Copy full SHA for 06c77f1
Fix Spring collision of beans implementing NetworkHelper

Antonio Fornie
authored and
wilderrodrigues
committed
5162d24
Copy full SHA for 5162d24
auto wire the network helper
wilderrodrigues
committed
808bbe3
Copy full SHA for 808bbe3
Refactor hypervisor retrieval from VpcNwHelper and NwHelper

Antonio Fornie
authored and
wilderrodrigues
committed
2e8879f
Copy full SHA for 2e8879f
Fixing NPE due to use of dependencies before Spring injection

Antonio Fornie
authored and
wilderrodrigues
committed
bdcaaa1
Copy full SHA for bdcaaa1
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues
committed
a6eca45
Copy full SHA for a6eca45
fixing nic plug unplug rule
wilderrodrigues
committed
6737ec9
Copy full SHA for 6737ec9
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
780de53
Copy full SHA for 780de53
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
fc8fe2c
Copy full SHA for fc8fe2c
Fix: VpcRouter has always PublicIp setup as it did before refactoring

Antonio Fornie
authored and
wilderrodrigues
committed
8785851
Copy full SHA for 8785851
making sure the instance variable _router in the Rules is being used instead of the parameter
wilderrodrigues
committed
a99f84c
Copy full SHA for a99f84c
removing the root password becuase it was breaking the simulator tests. Root password must always be empty
wilderrodrigues
committed
66b9c3c
Copy full SHA for 66b9c3c
Removing the VirtualNetworkStatus, it was not being used properly;
Show description for eaa86bb
wilderrodrigues
committed
eaa86bb
Copy full SHA for eaa86bb
Adding fixes for the add user data and vpn rules
wilderrodrigues
committed
45ed14c
Copy full SHA for 45ed14c
Changing the way the DAOs were being injected in the RuleApplier;
Show description for d971484
wilderrodrigues
committed
d971484
Copy full SHA for d971484
fixing checkstyle in the virtual network manager. problem appeared after a rebase. probably due to my saving action in the eclipse workspace
wilderrodrigues
committed
63afd36
Copy full SHA for 63afd36
Fixing the NetworkHelperImpl class. It was throwing a NPE due to a hypervisor type SIMULATOR not being in the hashmap.
Show description for 2d41f7b
wilderrodrigues
committed
2d41f7b
Copy full SHA for 2d41f7b
CLOUDSTACK-6278 Baremetal Advanced Networking support from commit id e06fa18ed2ee2ee6a417e089cf5ac6bde11d0079 by Frank Zhang
wilderrodrigues
committed
2dfc628
Copy full SHA for 2dfc628
Rules and visitors for Load Balance Rules

Antonio Fornie
authored and
wilderrodrigues
committed
849a4a1
Copy full SHA for 849a4a1
Adding new behaviour to the apply load balancing rules method. The whole chain has been implemented and we will now test it.
wilderrodrigues
committed
8373006
Copy full SHA for 8373006
Extract general behavior to Router and Vpc delegates

Antonio Fornie
authored and
wilderrodrigues
committed
9880a03
Copy full SHA for 9880a03
Fix dependency problem. Extract and unify router deployment stuff

Antonio Fornie
authored and
wilderrodrigues
committed
b963de0
Copy full SHA for b963de0
Adding Firewall Rules to comply with the Visitor pattern implementation; refactoring the applyRules so we can reuse it.

Wilder Rodrigues
authored and
wilderrodrigues
committed
36df702
Copy full SHA for 36df702
changing accessor modifier in instance variables

Wilder Rodrigues
authored and
wilderrodrigues
committed
40deb86
Copy full SHA for 40deb86
fixing checkstyles
wilderrodrigues
committed
6c131fd
Copy full SHA for 6c131fd
finished firewall rules and load balancing rules; fixed all the injection problems; added VirtualMachineManager to the appliance factory to be injected.
wilderrodrigues
committed
8ff5b09
Copy full SHA for 8ff5b09
TODO

DaanHoogland
authored and
wilderrodrigues
committed
611edd1
Copy full SHA for 611edd1
adding static nat rules. Deploying new VMs is not working due to the appliance refactory, will check the changes with Antonio tomorrow.
wilderrodrigues
committed
49b482b
Copy full SHA for 49b482b
we have to check if VPC is null bfore calling it. VPC is not used in gest networks, so deploying a new VM was broken.
wilderrodrigues
committed
89f0bb2
Copy full SHA for 89f0bb2
adding apache license headers
wilderrodrigues
committed
fa371e9
Copy full SHA for fa371e9
adding Ip Association and VPN Rules
wilderrodrigues
committed
26f5d23
Copy full SHA for 26f5d23
Fix offering setup

Antonio Fornie
authored and
wilderrodrigues
committed
28c0bf1
Copy full SHA for 28c0bf1
package rename

DaanHoogland
authored and
wilderrodrigues
committed
6c22f70
Copy full SHA for 6c22f70
Temporary put state info in a state object

Antonio Fornie
authored and
wilderrodrigues
committed
f2281b6
Copy full SHA for f2281b6
fixing the classes relationship; adding beans properly in the spring context; using the right basic/advance stuff; testing ip and port forwarding rules
wilderrodrigues
committed
986dbde
Copy full SHA for 986dbde
adding password to router rules; moving the advance code to the advance net topology.
wilderrodrigues
committed
6664cc1
Copy full SHA for 6664cc1
Unify and encapsulate deployment flow methods and params

Antonio Fornie
authored and
wilderrodrigues
committed
8a5459c
Copy full SHA for 8a5459c
adding userdata to router and ssh pub key to router rules.
wilderrodrigues
committed
de4a75b
Copy full SHA for de4a75b
making instance variables compliant with ACS convention
wilderrodrigues
committed
9b31d02
Copy full SHA for 9b31d02
adding user data pwd rules
wilderrodrigues
committed
d9670a1
Copy full SHA for d9670a1
adding DHCP entry rules
wilderrodrigues
committed
56723f2
Copy full SHA for 56723f2
fixing injection of beans with a relationship
wilderrodrigues
committed
0bbccc1
Copy full SHA for 0bbccc1
whitespace

DaanHoogland
authored and
wilderrodrigues
committed
f55746b
Copy full SHA for f55746b
fixing the injection of the networkDao
wilderrodrigues
committed
4e30701
Copy full SHA for 4e30701
mv to better name
Show description for 4537420

DaanHoogland
authored and
wilderrodrigues
committed
4537420
Copy full SHA for 4537420
Deployment more OO - Objects with data and behavior

Antonio Fornie
authored and
wilderrodrigues
committed
b098c0e
Copy full SHA for b098c0e
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues
committed
c66bfa1
Copy full SHA for c66bfa1
fixing import in virtual router element and checkstyle in dhcp entry related changes
wilderrodrigues
committed
7494bd6
Copy full SHA for 7494bd6
commenting broken code in tests in order to run build adn tests other changes via the UI
wilderrodrigues
committed
763f06e
Copy full SHA for 763f06e
removing bean from the xml
wilderrodrigues
committed
cd467bd
Copy full SHA for cd467bd
adding new bean to spring context file; renaming package from "com" to "org"
wilderrodrigues
committed
6834fe0
Copy full SHA for 6834fe0
Missing dependencies are added

Antonio Fornie
authored and
wilderrodrigues
committed
af2f734
Copy full SHA for af2f734
Fixing null pointers during vpc router deployment

Antonio Fornie
authored and
wilderrodrigues
committed
bab8b7e
Copy full SHA for bab8b7e
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues
committed
38dbd08
Copy full SHA for 38dbd08
fixing VPC IP Association and ACL rules. Have to rewrite in a better why the apply rules method in the Advanced Topology
wilderrodrigues
committed
e18521e
Copy full SHA for e18521e
Splitting Vpc and NonVpc deployment into phases & testing it

Antonio Fornie
authored and
wilderrodrigues
committed
44562f2
Copy full SHA for 44562f2
RouterDeployment and VPC. Improving code and Unit Testing

Antonio Fornie
authored and
wilderrodrigues
committed
a02ce1a
Copy full SHA for a02ce1a
rename networkMgr to networkMdl to prevent name clashes in mocks of
Show description for 2becb1a

DaanHoogland
authored and
wilderrodrigues
committed
2becb1a
Copy full SHA for 2becb1a
More refactoring and testing in the same classes

Antonio Fornie
authored and
wilderrodrigues
committed
934b200
Copy full SHA for 934b200
License headers

Antonio Fornie
authored and
wilderrodrigues
committed
12b21df
Copy full SHA for 12b21df
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
Show description for b53d66a
wilderrodrigues
committed
b53d66a
Copy full SHA for b53d66a
Complete tests for normal deployment and start vpc one

Antonio Fornie
authored and
wilderrodrigues
committed
37b8706
Copy full SHA for 37b8706
Factor out prepareDeployment and update tests

Antonio Fornie
authored and
wilderrodrigues
committed
450741d
Copy full SHA for 450741d
Increasing test coverage for Vpc Deployment

Antonio Fornie
authored and
wilderrodrigues
committed
da0c0db
Copy full SHA for da0c0db
Fix unnecessary changes Spring contexts

Antonio Fornie
authored and
wilderrodrigues
committed
07c459a
Copy full SHA for 07c459a
Adding VpcRouterDeploymentDefinition Unit Tests

Antonio Fornie
authored and
wilderrodrigues
committed
5fd9fc9
Copy full SHA for 5fd9fc9
moving sendCommand to the NetworkGeneralHelper;
Show description for fccd3ff
wilderrodrigues
committed
fccd3ff
Copy full SHA for fccd3ff
fixing check styles
wilderrodrigues
committed
b64ebba
Copy full SHA for b64ebba
Refactor to include network creation as actual deployment

Antonio Fornie
authored and
wilderrodrigues
committed
1768207
Copy full SHA for 1768207
adding applyStaticRoutes method to the network topology/visitor. it will be used by the VPC virtual net manager appliance.
wilderrodrigues
committed
5d9b445
Copy full SHA for 5d9b445
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues
committed
7c88411
Copy full SHA for 7c88411
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
Show description for 790b112
wilderrodrigues
committed
790b112
Copy full SHA for 790b112
DeployRouter includes nw creation following TellDontAsk principle
Show description for f22cf4d

Antonio Fornie
authored and
wilderrodrigues
committed
f22cf4d
Copy full SHA for f22cf4d
Whole router.deployment package got 97% coverage

Antonio Fornie
authored and
wilderrodrigues
committed
862a59a
Copy full SHA for 862a59a
adding setupPrivateGateway to new style;
Show description for f2a1b8d
wilderrodrigues
committed
f2a1b8d
Copy full SHA for f2a1b8d
fixing the private gateway rules in order to comply with changes in the vpc helper
wilderrodrigues
committed
0e93702
Copy full SHA for 0e93702
fixing check style issues
wilderrodrigues
committed
cc560e8
Copy full SHA for cc560e8
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers

Antonio Fornie
authored and
wilderrodrigues
committed
bb85d48
Copy full SHA for bb85d48
Missing license headers

Antonio Fornie
authored and
wilderrodrigues
committed
6500571
Copy full SHA for 6500571
refactor all private methods in the virtual router appliance and VPC appliance
wilderrodrigues
committed
453d7ec
Copy full SHA for 453d7ec
Fix Spring collision of beans implementing NetworkHelper

Antonio Fornie
authored and
wilderrodrigues
committed
734eda9
Copy full SHA for 734eda9
auto wire the network helper
wilderrodrigues
committed
0b96c7b
Copy full SHA for 0b96c7b
Refactor hypervisor retrieval from VpcNwHelper and NwHelper

Antonio Fornie
authored and
wilderrodrigues
committed
7235c23
Copy full SHA for 7235c23
Fixing NPE due to use of dependencies before Spring injection

Antonio Fornie
authored and
wilderrodrigues
committed
711f91c
Copy full SHA for 711f91c
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues
committed
c889bff
Copy full SHA for c889bff
fixing nic plug unplug rule
wilderrodrigues
committed
4d36e73
Copy full SHA for 4d36e73
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
70a76c9
Copy full SHA for 70a76c9
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
2569413
Copy full SHA for 2569413
Fix: VpcRouter has always PublicIp setup as it did before refactoring

Antonio Fornie
authored and
wilderrodrigues
committed
67328fb
Copy full SHA for 67328fb
making sure the instance variable _router in the Rules is being used instead of the parameter
wilderrodrigues
committed
8000f66
Copy full SHA for 8000f66
removing the root password becuase it was breaking the simulator tests. Root password must always be empty
wilderrodrigues
committed
c4b44d3
Copy full SHA for c4b44d3
Removing the VirtualNetworkStatus, it was not being used properly;
Show description for e6be15c
wilderrodrigues
committed
e6be15c
Copy full SHA for e6be15c
Adding fixes for the add user data and vpn rules
wilderrodrigues
committed
078f0af
Copy full SHA for 078f0af
Changing the way the DAOs were being injected in the RuleApplier;
Show description for 08afc76
wilderrodrigues
committed
08afc76
Copy full SHA for 08afc76
fixing checkstyle in the virtual network manager. problem appeared after a rebase. probably due to my saving action in the eclipse workspace
wilderrodrigues
committed
1f440e7
Copy full SHA for 1f440e7
Fixing the NetworkHelperImpl class. It was throwing a NPE due to a hypervisor type SIMULATOR not being in the hashmap.
Show description for 7575262
wilderrodrigues
committed
7575262
Copy full SHA for 7575262
CLOUDSTACK-6278 Baremetal Advanced Networking support from commit id e06fa18ed2ee2ee6a417e089cf5ac6bde11d0079 by Frank Zhang
wilderrodrigues
committed
557e15e
Copy full SHA for 557e15e
Merge branch 'vpc-refactor-rvr-final' of https://github.com/schubergphilis/cloudstack into vpc-refactor-rvr-final
wilderrodrigues
committed
ce471ed
Copy full SHA for ce471ed

Commits on Sep 23, 2014

Fixing problem with DHCP Subnet Rules.
Show description for 09d0d6f
wilderrodrigues
committed
09d0d6f
Copy full SHA for 09d0d6f

Search code, repositories, users, issues, pull requests...

Commits

Commits on Sep 11, 2014