[4.9] CLOUDSTACK-9692: Fix password server issue in redundant VRs#1871
Merged
asfgit merged 1 commit intoapache:4.9apache/cloudstack:4.9from Feb 3, 2017
ustcweizhou:RVR-passwd-serverustcweizhou/cloudstack:RVR-passwd-serverCopy head branch name to clipboard
Merged
[4.9] CLOUDSTACK-9692: Fix password server issue in redundant VRs#1871asfgit merged 1 commit intoapache:4.9apache/cloudstack:4.9from ustcweizhou:RVR-passwd-serverustcweizhou/cloudstack:RVR-passwd-serverCopy head branch name to clipboard
asfgit merged 1 commit intoapache:4.9apache/cloudstack:4.9from
ustcweizhou:RVR-passwd-serverustcweizhou/cloudstack:RVR-passwd-serverCopy head branch name to clipboard
Conversation
Member
|
@ustcweizhou is there an existing marvin test to validate this? |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
This function seems broken since 4.7. That's also one of the major reasons we are reluctant to upgrade to 4.9.x since we have quite a few clients using RVR now. I would suggest to review this and include this in 4.9.2 or 4.9.3 asap. Thanks ! |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-432 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-744)
|
The password server in RVRs has wrong parameters as the gateway of guest nics is None. In this case, we should get the gateway from /var/cache/cloud/cmdline.
e3b815f to
066b374
Compare
Contributor
Author
|
@rhtyd Could you please run the test again ? |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-441 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
is this ready to be merged ? |
Member
|
@rhtyd can you post the results of the previous test run? |
Member
|
@karuturi looks like it failed, I'll re-kick it |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-464 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Member
|
@rhtyd thanks |
|
Trillian test result (tid-790)
|
Contributor
|
I think tests look good now. LGTM |
borisstoyanov
approved these changes
Feb 2, 2017
Member
|
merging this now. |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2017
[4.9] CLOUDSTACK-9692: Fix password server issue in redundant VRsThe password server in RVRs has wrong parameters as the gateway of guest nics is None. In this case, we should get the gateway from /var/cache/cloud/cmdline. This issue is caused by commit 45642b8 * pr/1871: CLOUDSTACK-9692: Fix password server issue in redundant VRs Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password server in RVRs has wrong parameters as the gateway of guest nics is None.
In this case, we should get the gateway from /var/cache/cloud/cmdline.
This issue is caused by commit 45642b8