Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off#1852

Merged
karuturi merged 1 commit intomasterapache/cloudstack:masterfrom
unknown repositoryCopy head branch name to clipboard
Apr 27, 2017
Merged

CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off#1852
karuturi merged 1 commit intomasterapache/cloudstack:masterfrom
unknown repositoryCopy head branch name to clipboard

Conversation

@rashmidixit
Copy link

@rashmidixit rashmidixit commented Dec 22, 2016

Refer to CLOUDSTACK-9695 for more details.

@rashmidixit
Copy link
Author

rashmidixit commented Dec 22, 2016

As part of this fix, added a new property called "isDisabled" for a field in a dialog. If this function returns true, then the field will be disabled.

@yadvr
Copy link
Member

yadvr commented Dec 22, 2016

@rashmidixit change the PR's base branch to 4.9 please.

@rashmidixit rashmidixit changed the base branch from master to 4.9 December 22, 2016 09:27
@rashmidixit rashmidixit changed the base branch from 4.9 to master December 22, 2016 09:28
@rashmidixit
Copy link
Author

rashmidixit commented Dec 28, 2016

@rhtyd This is a minor improvement and hence in master. I have updated the corresponding bugs' fix version.

@rashmidixit rashmidixit changed the title VM snapshot is disabled if the VM Instance is off CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off Jan 3, 2017
@rashmidixit rashmidixit reopened this Jan 13, 2017
@koushik-das
Copy link
Contributor

koushik-das commented Jan 13, 2017

@rashmidixit Code LGTM. Please provide screenshots of the changes.

@ustcweizhou
Copy link
Contributor

ustcweizhou commented Jan 13, 2017

why not change vmActionfilter in ui/scripts/instances.js ?
it will be much simple.

@rashmidixit
Copy link
Author

rashmidixit commented Feb 28, 2017

@ustcweizhou The reason for not putting this in vmActionFilter is that the snapshot action itself is allowed when a VM is shut down. We only want to disable the option for memory snapshot which is not valid in this case. Hope this clarifies.

@rashmidixit
Copy link
Author

rashmidixit commented Feb 28, 2017 •
edited
Loading

ping @koushik-das.

When VM is running and snapshot option is clicked, the memory option is enabled.

vm-running-memorysnapshotenabled

When VM is stopped and snapshot option is clicked, the memory option is disabled.
vm-stopped-memorysnapshotdisabled

@ghost
Copy link

ghost commented Apr 20, 2017

Tested the functionality, working as desired.

instances

@ghost
Copy link

ghost commented Apr 20, 2017

vm in stopped state

vm in running state

@ghost
Copy link

ghost commented Apr 25, 2017

Test results are as desired. LGTM

@ramkatru
Copy link

ramkatru commented Apr 26, 2017

tag:mergeready

@resmo
Copy link
Member

resmo commented Apr 26, 2017

LGTM (based on code review)

@karuturi karuturi merged commit 64776f3 into apache:master Apr 27, 2017
@karuturi karuturi modified the milestone: 4.10.0.0 Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status:ready-for-merge type:enhancement

Projects

None yet

Milestone

4.10.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@rashmidixit @yadvr @koushik-das @ustcweizhou @ramkatru @resmo @karuturi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.