CLOUDSTACK-9304: Add nuagevsp userdata testcase (Cloudstack-9095) & Refactor existing testcases by sneeladh · Pull Request #1431 · apache/cloudstack

sneeladh · Mar 9, 2016

https://issues.apache.org/jira/browse/CLOUDSTACK-9304

Created folder / test / integration / plugins / nuagevsp
1. Moved test_nuage_vpc_network.py , test_nuage_vsp.py from / test / integration / component / � to---> / test / integration / plugins / nuagevsp/
2. Added new testcase test_nuage_password_reset.py (Cloudstack-9095)
3. Added Nuage class in / tools / marvin / marvin / lib / base.py
4. Added services in / tools / marvin / marvin / config / test_data.py

results:
test_01_UserDataPasswordReset (nuagevsp.test_nuage_password_reset.TestNuagePasswordReset) ... === TestName: test_01_UserDataPasswordReset | Status : SUCCESS ===
ok
Test Basic VPC Network Functionality with NuageVsp network Plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test NuageVsp network plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok

XML: /root/report_xunit.xml

PassLogs.zip

Ran 3 tests in 2406.256s

OK

CLOUDSTACK-9304

…testcases

new file: ../plugins/nuagevsp/__init__.py

sanju1010 · Mar 10, 2016

test/integration/component/test_nuage_vsp.py

-            physical_networks = cls.api_client.listPhysicalNetworks(resp)
-            for pn in physical_networks:
-                if pn.isolationmethods=='VSP':
-                    physical_network = pn


I would say come out of the loop as and when you find a physical network with isolation method as "VSP" unless the intention is to use multiple physical networks.

OK. We can add that.

@sanju1010 - Done..! Commited the change to the PR. Please review the same.

…SP is found modified: nuageTestCase.py

sanju1010 · Mar 11, 2016

LGTM based on the code review.

srikanteswartalluri · Mar 11, 2016

@sneeladh @shivsg Thanks for adding the tests, can you please run your code through pyflakes, pep8 and fix them ?

$ pyflakes *.py
nuageTestCase.py:52: 'attr' imported but unused
nuageTestCase.py:324: undefined name 'startVirtualMachine'
nuageTestCase.py:328: undefined name 'FAIL'
nuageTestCase.py:335: undefined name 'stopVirtualMachine'
nuageTestCase.py:341: undefined name 'FAIL'
test_nuage_password_reset.py:21: 'VirtualMachine' imported but unused
test_nuage_password_reset.py:21: 'PublicIPAddress' imported but unused
test_nuage_password_reset.py:26: 'createTemplate' imported but unused
test_nuage_password_reset.py:26: 'listVolumes' imported but unused
test_nuage_password_reset.py:64: undefined name 'cleanup_resources'
test_nuage_password_reset.py:72: undefined name 'list_volumes'
test_nuage_password_reset.py:84: undefined name 'Template'
test_nuage_password_reset.py:118: local variable 'vm_public_ip' is assigned to but never used
test_nuage_password_reset.py:217: undefined name 'startVirtualMachine'

sneeladh · Mar 15, 2016

Pep8 and Pyflakes compliant

[sneeladh@mvlinux26:nuagevsp]$
[sneeladh@mvlinux26:nuagevsp]$ pep8 --max-line-length=150 test_nuage_password_reset.py
[sneeladh@mvlinux26:nuagevsp]$ pep8 --max-line-length=150 test_nuage_vpc_network.py
[sneeladh@mvlinux26:nuagevsp]$ pep8 --max-line-length=150 test_nuage_vsp.py
[sneeladh@mvlinux26:nuagevsp]$ pep8 --max-line-length=150 nuageTestCase.py
[sneeladh@mvlinux26:nuagevsp]$

[sneeladh@mvlinux26:nuagevsp]$
[sneeladh@mvlinux26:nuagevsp]$ pyflakes nuageTestCase.py
[sneeladh@mvlinux26:nuagevsp]$ pyflakes test_nuage_password_reset.py
[sneeladh@mvlinux26:nuagevsp]$ pyflakes test_nuage_vpc_network.py
[sneeladh@mvlinux26:nuagevsp]$ pyflakes test_nuage_vsp.py
[sneeladh@mvlinux26:nuagevsp]$

[sneeladh@mvlinux26:nuagevsp]$
[sneeladh@mvlinux26:nuagevsp]$ pyflakes *.py
[sneeladh@mvlinux26:nuagevsp]$
[sneeladh@mvlinux26:nuagevsp]$

srikanteswartalluri · Mar 15, 2016

Jenkins failure is not related to these integration test changes, there are some junit tests failed

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project cloud-utils: There are test failures.
[ERROR]
[ERROR] Please refer to /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/utils/target/surefire-reports for the individual test results.

srikanteswartalluri · Mar 15, 2016

otherwise, it LGTM.

chinu2909 · Mar 16, 2016

LGTM based on the test results

test_01_UserDataPasswordReset (nuagevsp.test_nuage_password_reset.TestNuagePasswordReset) ... === TestName: test_01_UserDataPasswordReset | Status : SUCCESS ===
ok
Test Basic VPC Network Functionality with NuageVsp network Plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS ===
ok
Test NuageVsp network plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS ===
ok

Ran 3 tests in 2477.667s

OK

runinfo.txt
results.txt

CLOUDSTACK-9304: Add nuagevsp userdata testcase (Cloudstack-9095) & Refactor existing testcaseshttps://issues.apache.org/jira/browse/CLOUDSTACK-9304 1. Created folder / test / integration / plugins / nuagevsp 2. Moved test_nuage_vpc_network.py , test_nuage_vsp.py from / test / integration / component / to---> / test / integration / plugins / nuagevsp/ 3. Added new testcase test_nuage_password_reset.py (Cloudstack-9095) 4. Added Nuage class in / tools / marvin / marvin / lib / base.py 5. Added services in / tools / marvin / marvin / config / test_data.py results: test_01_UserDataPasswordReset (nuagevsp.test_nuage_password_reset.TestNuagePasswordReset) ... === TestName: test_01_UserDataPasswordReset | Status : SUCCESS === ok Test Basic VPC Network Functionality with NuageVsp network Plugin ... === TestName: test_nuage_vpc_network | Status : SUCCESS === ok Test NuageVsp network plugin with basic Isolated Network functionality ... === TestName: test_nuage_vsp | Status : SUCCESS === ok ---------------------------------------------------------------------- XML: /root/report_xunit.xml ---------------------------------------------------------------------- [PassLogs.zip](https://github.com/apache/cloudstack/files/164368/PassLogs.zip) Ran 3 tests in 2406.256s OK #CLOUDSTACK-9304 * pr/1431: Made the code Pyflakes compliant CLOUDSTACK-9304 - Exit loop when Physical Network with isolation as VSP is found modified: nuageTestCase.py CLOUDSTACK-9304 - Modified Description deleted: test_vpcnetwork_nuage.py new file: ../plugins/nuagevsp/__init__.py Add nuagevsp userdata testcase (Cloudstack-9095) & Refactor existing testcases Signed-off-by: Srikanteswararao Talluri <talluri@apache.org>

swill · Mar 17, 2016

I am not going to revert this merge at this time, but please ping me if you feel the PR is ready to be merged into master. Thx...

srikanteswartalluri · Mar 17, 2016

@swill Yes, PR is ready to be merged. Do you see any problem with that?

srikanteswartalluri · Mar 17, 2016

If the concern is jenkins build, I mentioned that the failures are not related to these integration test code but they are junit tests.

swill · Mar 17, 2016

It was already merged. I will leave it for now, but I will take note of this PR to validate it once my CI is up and running to make sure it does not cause any issues.

srikanteswartalluri · Mar 17, 2016

sure.

Substituição de `finalyzeAccountId` por `finalizeAccountId` Closes apache#1431 See merge request scclouds/scclouds!1142

Sowmya added 3 commits March 8, 2016 18:13

Add nuagevsp userdata testcase (Cloudstack-9095) & Refactor existing …

3c8d3d0

…testcases

deleted: test_vpcnetwork_nuage.py

2260263

new file: ../plugins/nuagevsp/__init__.py

CLOUDSTACK-9304 - Modified Description

255b746

sanju1010 reviewed Mar 10, 2016
View reviewed changes

CLOUDSTACK-9304 - Exit loop when Physical Network with isolation as V…

1446ecd

…SP is found modified: nuageTestCase.py

Made the code Pyflakes compliant

65d7ae3

asfgit merged commit 65d7ae3 into apache:master Mar 17, 2016

bernardodemarco pushed a commit to scclouds/cloudstack that referenced this pull request Jul 16, 2025

Merge branch 'resolve-typo' into '4.20.0.0-scclouds'

be6f233

Substituição de `finalyzeAccountId` por `finalizeAccountId` Closes apache#1431 See merge request scclouds/scclouds!1142

Search code, repositories, users, issues, pull requests...

Conversation

sneeladh commented Mar 9, 2016

CLOUDSTACK-9304

Uh oh!

sanju1010 Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

shivsg Mar 10, 2016

Choose a reason for hiding this comment

Uh oh!

sneeladh Mar 11, 2016

Choose a reason for hiding this comment

Uh oh!

sanju1010 commented Mar 11, 2016

Uh oh!

srikanteswartalluri commented Mar 11, 2016

Uh oh!

sneeladh commented Mar 15, 2016

Uh oh!

srikanteswartalluri commented Mar 15, 2016

Uh oh!

srikanteswartalluri commented Mar 15, 2016

Uh oh!

chinu2909 commented Mar 16, 2016

Uh oh!

swill commented Mar 17, 2016

Uh oh!

srikanteswartalluri commented Mar 17, 2016

Uh oh!

srikanteswartalluri commented Mar 17, 2016

Uh oh!

swill commented Mar 17, 2016

Uh oh!

srikanteswartalluri commented Mar 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants