Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

findbugs: new found old instance of DM_DEFAULT_ENCODING fixed#1427

Closed
DaanHoogland wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
DaanHoogland:newFoundOldBugDaanHoogland/cloudstack:newFoundOldBugCopy head branch name to clipboard
Closed

findbugs: new found old instance of DM_DEFAULT_ENCODING fixed#1427
DaanHoogland wants to merge 1 commit intoapache:masterapache/cloudstack:masterfrom
DaanHoogland:newFoundOldBugDaanHoogland/cloudstack:newFoundOldBugCopy head branch name to clipboard

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Mar 2, 2016

this quick fix to silence the findbugs
which seems to think this is a new issue

@DaanHoogland
findbugs: new found old instance of DM_DEFAULT_ENCODING fixed
c4a9ba1 
  this quick fix to silence the findbugs
   which seems to think this is a new issue
@swill
Copy link
Contributor

swill commented Mar 2, 2016

It looks like your IDE had a field day with this class. So other than the reordering of imports, adding final to a ton of variables and removing some unneeded brackets, this is really the only change? Right?

- String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes()).toString();
+ final String dir = UUID.nameUUIDFromBytes(nfsPath.getBytes(getPreferredCharset())).toString();

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Mar 2, 2016

:) @swill it is the only part I typed

@swill
Copy link
Contributor

swill commented Mar 2, 2016

Haha. Fair enough. I will let Raja test, but otherwise it LGTM.

@rafaelweingartner rafaelweingartner mentioned this pull request Mar 16, 2016
Merged
@rajap9711
Copy link

rajap9711 commented Mar 18, 2016

@DaanHoogland, @swill - LGTM
Ran BVT with XS 6.5 - all the test passed with the exception of the following tests due to env issues:
test_01_create_volume - ssh issue.
test_07_list_default_iso - iso didn't exist.
test_01_test_vm_volume_snapshot - test case issue - operation is not allowed?
best,
Raja

@DaanHoogland
Copy link
Contributor Author

DaanHoogland commented Mar 31, 2016

#1438 covers this

asfgit pushed a commit that referenced this pull request Mar 31, 2016
@rafaelweingartner
Merge pull request #1438 from rafaelweingartner/fixFindBugsBuild3455
2456500 
Fix new error found in findbugs slow build #3455Fix new find bug error that was introduced in PR #1361
Report: http://jenkins.buildacloud.org/job/build-master-slowbuild/3455/findbugsResult/new/

It is the same fix as the one proposed in #1427; the difference is that this PR tried to change only the code that was strictly needed. However, I took the liberty to remove a dead code and few lines of code (annotations) that were not needed

* pr/1438:
  Fix findbugs slow build 3455

Signed-off-by: Rafael Weingärtner <rafael@apache.org>
@DaanHoogland DaanHoogland deleted the newFoundOldBug branch August 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaanHoogland @swill @rajap9711
Morty Proxy This is a proxified and sanitized view of the page, visit original site.