ADD be explicit about the underlying limitation - OpenSwan#1426
Merged
asfgit merged 1 commit intoapache:masterapache/cloudstack:masterfrom Mar 10, 2016
Merged
ADD be explicit about the underlying limitation - OpenSwan#1426asfgit merged 1 commit intoapache:masterapache/cloudstack:masterfrom
asfgit merged 1 commit intoapache:masterapache/cloudstack:masterfrom
Conversation
Member
|
It seems a fair update. |
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Member
|
merging giving that it is a change only in a description of an enum and that we already have 2+ LGTM |
asfgit
pushed a commit
that referenced
this pull request
Mar 10, 2016
ADD be explicit about the underlying limitation - OpenSwanAccording to: http://linux.die.net/man/5/ipsec.secrets A preshared secret is most conveniently represented as a sequence of characters, delimited by the double-quote character ("). The sequence cannot contain a newline or double-quote. * pr/1426: ADD be explicit about the underlying limitation - OpenSwan Signed-off-by: Rafael Weingärtner <rafael@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to:
http://linux.die.net/man/5/ipsec.secrets
A preshared secret is most conveniently represented as a sequence of characters, delimited by the double-quote character ("). The sequence cannot contain a newline or double-quote.