Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

CKS: skip default egress policy check for vpc network offerings#11998

Merged
shwstppr merged 2 commits intoapache:4.22apache/cloudstack:4.22from
weizhouapache:4.22-fix-cks-vpc-networkweizhouapache/cloudstack:4.22-fix-cks-vpc-networkCopy head branch name to clipboard
Jan 28, 2026
Merged

CKS: skip default egress policy check for vpc network offerings#11998
shwstppr merged 2 commits intoapache:4.22apache/cloudstack:4.22from
weizhouapache:4.22-fix-cks-vpc-networkweizhouapache/cloudstack:4.22-fix-cks-vpc-networkCopy head branch name to clipboard

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Nov 6, 2025

Description

This PR fixes #11995

Steps to reproduce the issue

  • create a vpc
  • create a vpc tier with default offering DefaultIsolatedNetworkOfferingForVpcNetworks
  • register CKS ISO
  • create CKS on the vpc tier

expected: succeed
actual: failed with error Kubernetes service has not been configured properly to provision Kubernetes clusters

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.22.1 milestone Nov 6, 2025
@weizhouapache weizhouapache linked an issue Nov 6, 2025 that may be closed by this pull request
Generate a default "DefaultNetworkOfferingforKubernetesService" for vpc networks #11995
Closed
@weizhouapache
Copy link
Member Author

weizhouapache commented Nov 6, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (516012a) to head (e771ca0).
⚠️ Report is 127 commits behind head on 4.22.

Files with missing lines Patch % Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.22   #11998   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
+ Complexity    15546    15545    -1     
=========================================
  Files          5910     5910           
  Lines        529125   529125           
  Branches      64628    64628           
=========================================
+ Hits          92934    92939    +5     
+ Misses       425737   425733    -4     
+ Partials      10454    10453    -1
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15648

@weizhouapache
Copy link
Member Author

weizhouapache commented Nov 6, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 6, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 7, 2025

[SF] Trillian test result (tid-14774)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11998-t14774-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Pearl1594
Pearl1594 approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache added the Severity:Critical Critical bug label Nov 28, 2025
@weizhouapache weizhouapache marked this pull request as ready for review November 28, 2025 19:00
vishesh92
vishesh92 approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rajujith rajujith moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026
@kiranchavala
Copy link
Member

kiranchavala commented Jan 27, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2026

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 27, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16548

kiranchavala
kiranchavala approved these changes Jan 27, 2026
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  1. Create a VPC network and tier with ACL ( allow all)

  2. Launch a cks cluster in the vpc network

  3. CKS cluster launched successfully

  4. Launch a nginx deployment on the cks cluster

  5. Nginx deployment launched fine

@shwstppr
Copy link
Contributor

shwstppr commented Jan 28, 2026

Merging based on tests and review

@shwstppr shwstppr merged commit 2bfc9cb into apache:4.22 Jan 28, 2026
25 of 26 checks passed
@shwstppr shwstppr mentioned this pull request Jan 28, 2026
Closed
@DaanHoogland DaanHoogland deleted the 4.22-fix-cks-vpc-network branch January 28, 2026 08:04
sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
@weizhouapache
CKS: skip default egress policy check for vpc network offerings (apac…
d5f5698 
…he#11998)

This PR fixes apache#11995

Steps to reproduce the issue
- create a vpc
- create a vpc tier with default offering `DefaultIsolatedNetworkOfferingForVpcNetworks`
- register CKS ISO
- create CKS on the vpc tier

expected: succeed
actual: failed with error `Kubernetes service has not been configured properly to provision Kubernetes clusters`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

@kiranchavala kiranchavala

Labels

component:cks component:kubernetes Severity:Critical Critical bug

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

Generate a default "DefaultNetworkOfferingforKubernetesService" for vpc networks

7 participants

@weizhouapache @blueorangutan @kiranchavala @shwstppr @vishesh92 @Pearl1594 @DaanHoogland
Morty Proxy This is a proxified and sanitized view of the page, visit original site.